Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestClientTimeoutReturnsContextDeadlineExceeded failures #65287

Closed
gopherbot opened this issue Jan 25, 2024 · 24 comments
Closed

net/http: TestClientTimeoutReturnsContextDeadlineExceeded failures #65287

gopherbot opened this issue Jan 25, 2024 · 24 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Go1.23

Comments

@gopherbot
Copy link

gopherbot commented Jan 25, 2024 •
edited by cherrymui 

#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientTimeoutReturnsContextDeadlineExceeded`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.02s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.01s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:62965": dial tcp 127.0.0.1:62965: i/o timeout (Client.Timeout exceeded while awaiting headers)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 25, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test == "TestClientTimeoutReturnsContextDeadlineExceeded"
2024-01-25 19:32 solaris-amd64-oraclerel go@4fde3ef2 net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.02s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.01s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:62965": dial tcp 127.0.0.1:62965: i/o timeout (Client.Timeout exceeded while awaiting headers)
2024-01-25 19:43 freebsd-386-13_0 go@6a861010 net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.00s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h2 (0.00s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "https://127.0.0.1:57094": dial tcp 127.0.0.1:57094: i/o timeout (Client.Timeout exceeded while awaiting headers)
2024-01-25 19:43 linux-loong64-3a5000 go@6a861010 net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.00s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.02s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:40339": dial tcp 127.0.0.1:40339: i/o timeout (Client.Timeout exceeded while awaiting headers)
2024-01-25 19:43 solaris-amd64-oraclerel go@6a861010 net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.00s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.00s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:61537": dial tcp 127.0.0.1:61537: i/o timeout (Client.Timeout exceeded while awaiting headers)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientTimeoutReturnsContextDeadlineExceeded`
2024-01-25 19:32 gotip-darwin-amd64_12 go@4fde3ef2 net/http.TestClientTimeoutReturnsContextDeadlineExceeded/h2 (log) 
=== RUN   TestClientTimeoutReturnsContextDeadlineExceeded/h2
=== PAUSE TestClientTimeoutReturnsContextDeadlineExceeded/h2
=== CONT  TestClientTimeoutReturnsContextDeadlineExceeded/h2
    client_test.go:2146: expected context.DeadlineExceeded, got Get "https://127.0.0.1:60782": dial tcp 127.0.0.1:60782: i/o timeout (Client.Timeout exceeded while awaiting headers)
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h2 (0.01s)
2024-01-25 19:43 gotip-linux-amd64-race go@6a861010 net/http.TestClientTimeoutReturnsContextDeadlineExceeded/h2 (log) 
=== RUN   TestClientTimeoutReturnsContextDeadlineExceeded/h2
=== PAUSE TestClientTimeoutReturnsContextDeadlineExceeded/h2
=== CONT  TestClientTimeoutReturnsContextDeadlineExceeded/h2
    client_test.go:2146: expected context.DeadlineExceeded, got Get "https://127.0.0.1:44297": dial tcp 127.0.0.1:44297: i/o timeout (Client.Timeout exceeded while awaiting headers)
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h2 (0.00s)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientTimeoutReturnsContextDeadlineExceeded`
2024-01-25 23:12 linux-amd64-nocgo go@5c7c24ce net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.00s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.00s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:41525": dial tcp 127.0.0.1:41525: i/o timeout (Client.Timeout exceeded while awaiting headers)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientTimeoutReturnsContextDeadlineExceeded`
2024-01-25 23:12 darwin-amd64-10_15 go@5c7c24ce net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.00s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h2 (0.01s)
        clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:51370: EOF
        client_test.go:2146: expected context.DeadlineExceeded, got Get "https://127.0.0.1:51369": dial tcp 127.0.0.1:51369: i/o timeout (Client.Timeout exceeded while awaiting headers)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientTimeoutReturnsContextDeadlineExceeded`
2024-01-25 22:04 gotip-solaris-amd64 go@93f0c0b2 net/http.TestClientTimeoutReturnsContextDeadlineExceeded/h1 (log) 
=== RUN   TestClientTimeoutReturnsContextDeadlineExceeded/h1
=== PAUSE TestClientTimeoutReturnsContextDeadlineExceeded/h1
=== CONT  TestClientTimeoutReturnsContextDeadlineExceeded/h1
    client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:42105": dial tcp 127.0.0.1:42105: i/o timeout (Client.Timeout exceeded while awaiting headers)
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.00s)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientTimeoutReturnsContextDeadlineExceeded`
2024-01-25 23:27 linux-mips64-rtrk go@bdb0a1ab net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.00s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.00s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:43781": dial tcp 127.0.0.1:43781: i/o timeout (Client.Timeout exceeded while awaiting headers)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientTimeoutReturnsContextDeadlineExceeded`
2024-01-25 23:27 darwin-amd64-longtest go@bdb0a1ab net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.04s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h2 (0.02s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "https://127.0.0.1:50295": dial tcp 127.0.0.1:50295: i/o timeout (Client.Timeout exceeded while awaiting headers)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientTimeoutReturnsContextDeadlineExceeded`
2024-01-26 04:31 netbsd-arm64-bsiegert go@3dcdc09c net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.00s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.00s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:60889": dial tcp 127.0.0.1:60889: i/o timeout (Client.Timeout exceeded while awaiting headers)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientTimeoutReturnsContextDeadlineExceeded`
2024-01-26 04:31 darwin-amd64-13 go@d278d5bb net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.00s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h2 (0.02s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "https://127.0.0.1:51152": dial tcp 127.0.0.1:51152: i/o timeout (Client.Timeout exceeded while awaiting headers)
        clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:51153: read tcp 127.0.0.1:51152->127.0.0.1:51153: use of closed network connection

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Jan 26, 2024

This test was added in https://go.dev/cl/533119 (attn @neild @yunginnanet).

@bcmills bcmills added Soon This needs to be done soon. (regressions, serious bugs, outages) release-blocker labels Jan 26, 2024
@bcmills bcmills added this to the Go1.23 milestone Jan 26, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientTimeoutReturnsContextDeadlineExceeded`
2024-01-25 15:53 openbsd-arm-jsing go@67d30fc3 net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.00s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.00s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:24956": dial tcp 127.0.0.1:24956: i/o timeout (Client.Timeout exceeded while awaiting headers)
2024-01-25 23:12 openbsd-arm-jsing go@5c7c24ce net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.00s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.00s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:47517": dial tcp 127.0.0.1:47517: i/o timeout (Client.Timeout exceeded while awaiting headers)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h2 (0.01s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "https://127.0.0.1:46302": dial tcp 127.0.0.1:46302: i/o timeout (Client.Timeout exceeded while awaiting headers)
        clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:30933: read tcp 127.0.0.1:46302->127.0.0.1:30933: use of closed network connection
2024-01-26 01:41 openbsd-arm-jsing go@09ed9a65 net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.00s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.00s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:25195": dial tcp 127.0.0.1:25195: i/o timeout (Client.Timeout exceeded while awaiting headers)
2024-01-26 04:31 openbsd-arm64-jsing go@d278d5bb net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.00s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.00s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:10527": dial tcp 127.0.0.1:10527: i/o timeout (Client.Timeout exceeded while awaiting headers)

— watchflakes

@cherrymui
Copy link
Member

The failure rate looks pretty high. Perhaps we should roll back the CL and try later.

@gopherbot
Copy link
Author

Change https://go.dev/cl/558916 mentions this issue: Revert "net/http: wrap client errors"

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientTimeoutReturnsContextDeadlineExceeded`
2024-01-26 17:17 windows-amd64-race go@b1a12dd2 net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.00s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.00s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:51310": dial tcp 127.0.0.1:51310: i/o timeout (Client.Timeout exceeded while awaiting headers)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientTimeoutReturnsContextDeadlineExceeded`
2024-01-26 04:31 gotip-linux-amd64-staticlockranking go@3dcdc09c net/http.TestClientTimeoutReturnsContextDeadlineExceeded/h1 (log) 
=== RUN   TestClientTimeoutReturnsContextDeadlineExceeded/h1
=== PAUSE TestClientTimeoutReturnsContextDeadlineExceeded/h1
=== CONT  TestClientTimeoutReturnsContextDeadlineExceeded/h1
    client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:46599": dial tcp 127.0.0.1:46599: i/o timeout (Client.Timeout exceeded while awaiting headers)
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.00s)
2024-01-26 16:28 gotip-darwin-arm64_12 go@5dceddfe net/http.TestClientTimeoutReturnsContextDeadlineExceeded/h2 (log) 
=== RUN   TestClientTimeoutReturnsContextDeadlineExceeded/h2
=== PAUSE TestClientTimeoutReturnsContextDeadlineExceeded/h2
=== CONT  TestClientTimeoutReturnsContextDeadlineExceeded/h2
    client_test.go:2146: expected context.DeadlineExceeded, got Get "https://127.0.0.1:52595": dial tcp 127.0.0.1:52595: i/o timeout (Client.Timeout exceeded while awaiting headers)
    clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:52596: read tcp 127.0.0.1:52595->127.0.0.1:52596: use of closed network connection
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h2 (0.02s)
2024-01-26 16:28 gotip-linux-amd64-newinliner go@5dceddfe net/http.TestClientTimeoutReturnsContextDeadlineExceeded/h1 (log) 
=== RUN   TestClientTimeoutReturnsContextDeadlineExceeded/h1
=== PAUSE TestClientTimeoutReturnsContextDeadlineExceeded/h1
=== CONT  TestClientTimeoutReturnsContextDeadlineExceeded/h1
    client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:36237": dial tcp 127.0.0.1:36237: i/o timeout (Client.Timeout exceeded while awaiting headers)
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.02s)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientTimeoutReturnsContextDeadlineExceeded`
2024-01-26 17:17 linux-riscv64-unmatched go@c21d118a net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.00s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.00s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:43127": dial tcp 127.0.0.1:43127: i/o timeout (Client.Timeout exceeded while awaiting headers)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientTimeoutReturnsContextDeadlineExceeded`
2024-01-26 16:28 openbsd-arm-jsing go@5dceddfe net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.00s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.00s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:33953": dial tcp 127.0.0.1:33953: i/o timeout (Client.Timeout exceeded while awaiting headers)

— watchflakes

@yunginnanet
Copy link
Contributor

yunginnanet commented Jan 27, 2024 •
edited

where is the best place to discuss this test failing?

it's odd to me that we're seeing this, given the following source from net.go:

go/src/net/net.go

Lines 581 to 602 in 99efe7c

// errTimeout exists to return the historical "i/o timeout" string
// for context.DeadlineExceeded. See mapErr.
// It is also used when Dialer.Deadline is exceeded.
// error.Is(errTimeout, context.DeadlineExceeded) returns true.
//
// TODO(iant): We could consider changing this to os.ErrDeadlineExceeded
// in the future, if we make
//
// errors.Is(os.ErrDeadlineExceeded, context.DeadlineExceeded)
//
// return true.
var errTimeout error = &timeoutError{}
type timeoutError struct{}
func (e *timeoutError) Error() string { return "i/o timeout" }
func (e *timeoutError) Timeout() bool { return true }
func (e *timeoutError) Temporary() bool { return true }
func (e *timeoutError) Is(err error) bool {
return err == context.DeadlineExceeded
}

which seems to explicitly notate that this test shouldn't fail when receiving an i/o timeout in the Error() method return.

i guess the only way this makes sense is if at some point in the chain of returns an error isn't being wrapped, and instead the string of an Error() method return is being appended to a new error implementation's Error() return.

additionally curious is the fact that this got past LUCI... the answer to this second question is likely more clear to contributors that aren't as fresh as I am. it seems that the answer to this second question may take us to the cause(s) of the problem, though.

CC: @neild

@yunginnanet
Copy link
Contributor

see here: https://go-review.googlesource.com/c/go/+/533119/comment/9133758c_cc35a308/

@yunginnanet yunginnanet mentioned this issue Jan 27, 2024
Open
@gopherbot
Copy link
Author

Change https://go.dev/cl/559035 mentions this issue: net/http: wrap client errors

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientTimeoutReturnsContextDeadlineExceeded`
2024-01-26 17:17 netbsd-arm64-bsiegert go@c21d118a net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.00s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.00s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:54019": dial tcp 127.0.0.1:54019: i/o timeout (Client.Timeout exceeded while awaiting headers)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientTimeoutReturnsContextDeadlineExceeded`
2024-01-26 17:19 linux-mips64-rtrk go@3e789713 net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.00s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h1 (0.00s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "http://127.0.0.1:33485": dial tcp 127.0.0.1:33485: i/o timeout (Client.Timeout exceeded while awaiting headers)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientTimeoutReturnsContextDeadlineExceeded`
2024-01-25 22:04 openbsd-arm64-jsing go@93f0c0b2 net/http.TestClientTimeoutReturnsContextDeadlineExceeded (log) 
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded (0.00s)
    --- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h2 (0.00s)
        client_test.go:2146: expected context.DeadlineExceeded, got Get "https://127.0.0.1:6174": dial tcp 127.0.0.1:6174: i/o timeout (Client.Timeout exceeded while awaiting headers)
        clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:28123: read tcp 127.0.0.1:6174->127.0.0.1:28123: use of closed network connection

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test ~ `TestClientTimeoutReturnsContextDeadlineExceeded`
2024-01-26 17:17 gotip-linux-riscv64 go@b1a12dd2 net/http.TestClientTimeoutReturnsContextDeadlineExceeded/h2 (log) 
=== RUN   TestClientTimeoutReturnsContextDeadlineExceeded/h2
=== PAUSE TestClientTimeoutReturnsContextDeadlineExceeded/h2
=== CONT  TestClientTimeoutReturnsContextDeadlineExceeded/h2
    client_test.go:2146: expected context.DeadlineExceeded, got Get "https://127.0.0.1:40165": dial tcp 127.0.0.1:40165: i/o timeout (Client.Timeout exceeded while awaiting headers)
--- FAIL: TestClientTimeoutReturnsContextDeadlineExceeded/h2 (0.01s)

— watchflakes

ezz-no pushed a commit to ezz-no/go-ezzno that referenced this issue Feb 18, 2024
@cherrymui @ezz-no
Revert "net/http: wrap client errors"
d6090a7 
This reverts CL 533119.

Reason for revert: the test fails frequently, see golang#65287.

Fixes golang#65287.

Change-Id: I5bf2ee2b7ce435608ff76b892da261c0a4a189bf
Reviewed-on: https://go-review.googlesource.com/c/go/+/558916
Reviewed-by: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Cherry Mui <cherryyz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
Test Flakes
Status: Done
Milestone
Go1.23
Development

No branches or pull requests
4 participants
@bcmills @gopherbot @cherrymui @yunginnanet