Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestServerReaderFromOrder failures #65280

Closed
gopherbot opened this issue Jan 25, 2024 · 3 comments
Closed

net/http: TestServerReaderFromOrder failures #65280

gopherbot opened this issue Jan 25, 2024 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link

gopherbot commented Jan 25, 2024 •
edited by bcmills 

#!watchflakes
post <- pkg == "net/http" && test == "TestServerReaderFromOrder"  && `handler Copy = 0; want `

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestServerReaderFromOrder (0.00s)
    --- FAIL: TestServerReaderFromOrder/h1 (0.06s)
        serve_test.go:3881: handler Copy = 0; want 3145728
        serve_test.go:3902: Body = ""; want hi

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 25, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test == "TestServerReaderFromOrder"
2024-01-09 18:15 linux-amd64-boringcrypto go@a95136a8 net/http.TestServerReaderFromOrder (log) 
--- FAIL: TestServerReaderFromOrder (0.00s)
    --- FAIL: TestServerReaderFromOrder/h1 (0.06s)
        serve_test.go:3881: handler Copy = 0; want 3145728
        serve_test.go:3902: Body = ""; want hi

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Jan 25, 2024 •
edited

This is the regression test for #5660.

Actually, given the other failures in that test log (#56421 (comment)), I suspect that this was caused by a stray Dial from another test after a port used by that other test was reused in TestServerReaderFromOrder.

This might also explain #59038.

@bcmills
Copy link
Contributor

bcmills commented Jan 30, 2024

Commit a95136a is also on release-branch.go1.20; closing as “possibly obsolete”.

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcmills @gopherbot