Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: net: separate net.Dialer Resolver into a Interface #65275

Closed
Jack-Kingdom opened this issue Jan 25, 2024 · 2 comments
Closed

proposal: net: separate net.Dialer Resolver into a Interface #65275

Jack-Kingdom opened this issue Jan 25, 2024 · 2 comments
Labels
Proposal WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Proposal

Comments

@Jack-Kingdom
Copy link

Proposal Details

Resolver in net.Dialer is a struct, I found its hard to custom dns request for doh (dns over https) or dot (dns over tls).

Screen Shot 2024-01-25 at 4 11 51 PM Screen Shot 2024-01-25 at 4 15 16 PM

We can wrap Resolver into a interface, so that everyone could implement their own dns handle procedure
@mateusz834
Copy link
Member

What API changes are you proposing here?

@mateusz834 mateusz834 added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jan 25, 2024
@mateusz834 mateusz834 changed the title net/dial: separate net.Dialer Resolver into a Interface proposal: net/dial: separate net.Dialer Resolver into a Interface Jan 25, 2024
@gopherbot gopherbot added this to the Proposal milestone Jan 25, 2024
@mateusz834 mateusz834 changed the title proposal: net/dial: separate net.Dialer Resolver into a Interface proposal: net: separate net.Dialer Resolver into a Interface Jan 25, 2024
@seankhliao
Copy link
Member

Duplicate of #12503

@seankhliao seankhliao marked this as a duplicate of #12503 Jan 25, 2024
@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Proposal WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Proposal
Development

No branches or pull requests
4 participants
@gopherbot @Jack-Kingdom @seankhliao @mateusz834