Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/golangbuild: also move or delete untested nested modules for run-tests-outside-repository check #65267

Open
dmitshur opened this issue Jan 24, 2024 · 0 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jan 24, 2024

One of the items implemented in #60666 was:

  • run subrepo tests from outside their repositories (equivalent to x/build/cmd/coordinator's go.dev/issue/34352)

The repoToModules function is responsible for finding modules in repoDir to be tested, and for repos without local replace directives, it also moves nested modules to directories that aren't predictably-relative to each other.

It's right for repoToModules to skip over directories that aren't intended to have testable modules (for example, directories with "." or "_" prefixes, or named "testdata"), but they should still be visited for the purpose of moving them to an unpredictable location (or, removing them entirely, since their content isn't needed for running tests).

Filing this to track that fix. When rolling it out, it's worth paying attention to how many newly failing tests it begins to catch, and to give them an opportunity to be fixed or otherwise handled without undue time pressure.

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 24, 2024
@dmitshur dmitshur added this to the Unreleased milestone Jan 24, 2024
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Status: Planned
Development

No branches or pull requests

2 participants