Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: include all first-class ports in TryBot coverage for x repos against previous Go releases #65235

Open
bcmills opened this issue Jan 23, 2024 · 2 comments
Open

x/build: include all first-class ports in TryBot coverage for x repos against previous Go releases #65235

bcmills opened this issue Jan 23, 2024 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 23, 2024

Go version

a95136a

Output of go env in your module/workspace:

N/A

What did you do?

Observe #65223.

What did you see happen?

Test failures for the x/sys repo on release-branch.go1.20 on windows as of https://go.dev/cl/556895, which had a LUCI-TryBot-Result +1 vote.

What did you expect to see?

Since https://go.dev/cl/556895 had a passing TryBot run, it should not have introduced failures on any supported release branch on any first class port.
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jan 23, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jan 23, 2024
@cherrymui cherrymui added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 23, 2024
@dmitshur
Copy link
Contributor

Issue #17626 was having golang.org/x trybots have any kind of coverage for previous supported Go releases.
The linux/amd64 builder was chosen as it was highly available and least expensive, and was a significant improvement compared to no coverage at all. But, it indeed is limited and doesn't catch problems that affect other OSes only on older Go versions.

It would certainly be good if we're able to expand this to cover more ports, and since we already consider breakages in first-class ports to block releases, adding first-class port trybot coverage makes a good next target. Adding FeatureRequest label since this is an enhancement.

@dmitshur dmitshur changed the title x/build: missing TryBot coverage for x repos on release branches x/build: include all first-class ports in TryBot coverage for x repos against previous Go releases Jan 23, 2024
@dmitshur
Copy link
Contributor

CL 568197 added previous Go release coverage for 3 more first-class ports: linux/386, darwin/amd64, and windows/amd64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release
Status: Planned
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @bcmills @gopherbot @cherrymui