Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/windows: test fails to build on Go 1.20 due to use of the slices package #65223

Closed
gopherbot opened this issue Jan 23, 2024 · 3 comments
Closed

x/sys/windows: test fails to build on Go 1.20 due to use of the slices package #65223

gopherbot opened this issue Jan 23, 2024 · 3 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. OS-Windows release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@gopherbot
Copy link

gopherbot commented Jan 23, 2024 •
edited by bcmills 

#!watchflakes
post <- pkg == "golang.org/x/sys/windows" && log ~ `package slices is not in GOROOT`

Issue created automatically to collect these failures.

Example (log):

windows\env_windows_test.go:9:2: package slices is not in GOROOT (C:\workdir\go\src\slices)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 23, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/sys/windows" && test == ""
2024-01-23 00:04 windows-386-2016 sys@c3fa2b8b go@a95136a8 x/sys/windows [build] (log) 
windows\env_windows_test.go:9:2: package slices is not in GOROOT (C:\workdir\go\src\slices)
2024-01-23 00:04 windows-amd64-2016 sys@c3fa2b8b go@a95136a8 x/sys/windows [build] (log) 
windows\env_windows_test.go:9:2: package slices is not in GOROOT (C:\workdir\go\src\slices)
2024-01-23 00:04 windows-amd64-race sys@c3fa2b8b go@a95136a8 x/sys/windows [build] (log) 
windows\env_windows_test.go:9:2: package slices is not in GOROOT (C:\workdir\go\src\slices)

— watchflakes

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jan 23, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jan 23, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/sys/windows" && test == ""
2024-01-23 00:04 windows-arm64-11 sys@c3fa2b8b go@a95136a8 x/sys/windows [build] (log) 
windows\env_windows_test.go:9:2: package slices is not in GOROOT (C:\workdir\go\src\slices)

— watchflakes

@bcmills bcmills mentioned this issue Jan 23, 2024
Open
@bcmills bcmills added FixPending Issues that have a fix which has not yet been reviewed or submitted. Testing An issue that has been verified to require only test changes, not just a test failure. labels Jan 23, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/557975 mentions this issue: windows: build env_windows_test.go only go Go 1.21 and above

@bcmills bcmills added OS-Windows NeedsFix The path to resolution is known, but the work has not been done. labels Jan 23, 2024
@bcmills bcmills modified the milestones: Unreleased, Go1.20.14 Jan 23, 2024
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 23, 2024
@bcmills bcmills changed the title x/sys/windows: unrecognized failures x/sys/windows: test fails to build due to use of a Go 1.21 package Jan 23, 2024
@bcmills bcmills changed the title x/sys/windows: test fails to build due to use of a Go 1.21 package x/sys/windows: test fails to build on Go 1.20 due to use of the slices package Jan 23, 2024
@mknyszek mknyszek modified the milestones: Go1.20.14, Unreleased Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. OS-Windows release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@mknyszek @bcmills @gopherbot