Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http/pprof,runtime/pprof: document expected overhead of profiling #65208

Open
seankhliao opened this issue Jan 22, 2024 · 1 comment
Open

net/http/pprof,runtime/pprof: document expected overhead of profiling #65208

seankhliao opened this issue Jan 22, 2024 · 1 comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. Documentation NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@seankhliao
Copy link
Member

A common question from users is how much overhead it is to add profiling (most commonly through net/http/pprof) into a running production system, and whether it's safe to just leave it in a non-debug build.

The package doc should state the expected / target impact of just importing the package (negligible?) and when actively running a cpu/memory profile.

The last time the Go project seems to have said something about this was 10 years ago in a blog post while people appear to cite 5% coming from Google Cloud Profiler
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jan 22, 2024
@cherrymui cherrymui added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 23, 2024
@cherrymui cherrymui added this to the Backlog milestone Jan 23, 2024
@mknyszek
Copy link
Contributor

In compiler/runtime triage, we think this is a good idea, but we need to figure out what number to write down (and how to determine it). Maybe we need to add this to our benchmark dashboard?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. Documentation NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Compiler / Runtime
Status: Todo
Milestone
Backlog
Development

No branches or pull requests
4 participants
@mknyszek @gopherbot @seankhliao @cherrymui