-
Notifications
You must be signed in to change notification settings - Fork 18k
x/vuln: Publish binaries & checksums #65206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What security properties you would get with this that |
We would like to have the binaries and its checksums to use them in the environment without internet. |
Just to make sure I understand. You would clearly get the binaries with the internet anyhow, but once you put them in your environment that has no internet connection, you'd like to check that they have not been malformed during the life span of the environment? |
Yes that's right. Right now, we must compile govulncheck from the code source, make our own checksum of the binary, store it and check it after in our environment. |
Since Go supports verifiable builds as of 1.21.0, you can in principle compare the binaries without storing the checksum on disk. Either way, it seems that you have something working? |
To further add, it seems to me that what you are doing is basically I will leave the discussion open for a bit. |
Rather than have a checksum, is it possible to have a cryptographic signature of the binaries (for example, gosec already does that: https://github.com/securego/gosec/releases/tag/v2.18.2) ? |
It is still not clear why not trust Either way, we don't distribute binaries. Tools in golang repos also don't provide checksums/crypto signatures except for the go command. Given all of this and the fact that you already have a working solution, I am closing this issue. |
Hi, is it possible to publish the binaries & checksums for each version of govulncheck ?
The text was updated successfully, but these errors were encountered: