cmd/go: get can't fetch packages sources without dots in the base name #6520
Labels
FrozenDueToAge
NeedsDecision
Feedback is required from experts, contributors, and/or the community before a change can be made.
WaitingForInfo
Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Comments
Again, at least for git, it tries to use the given URL as a relative file-system path,
which is neither broadly available nor unique.
From reading vcs.go and get.go, the flow roughly reads like this:
1. Remote schemas are tried when repoRootForImportPath() (whic doesn't return an error despite not finding anything...)
2. No result? Then it must be the first element in $GOPATH
3. Call vcs.create() on the folder to import the package. As it expects it to be a local package, the remote path is prefixed by $GOPATH[0]. In the case of GIT, the clone-command exits with status 128, thus making go get fail as a whole.
On a side note, get.go's downloadPackage() has a code (roughly) on the form
if x != "" {
...
} else {
...
}
if x == "" {
...
}
which looks like the else and second if-statement should be catenated together. Should I
submit a change-request?
|
|
I am triaging it again. Design of "go get" is about downloading packages from remote internet hosts, it means a domain with dot. If one wants to handle this for the local hostnames then it is possible to use local hostnames with a dot. I am not sure that we want to handle this case on the side of ping @msiebuhr |
ysmolski
added
WaitingForInfo
|
Timed out in state WaitingForInfo. Closing. (I am just a bot, though. Please speak up if this is a mistake or you have the requested information.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What steps will reproduce the problem? 1. Run go get -x localhost/foo.git 2. Run go get -x 127.0.0.1/foo.git What is the expected output? The output of the two commands should match (except hostname/ip difference). What do you see instead? The command that fetches from localhost fails (unrecognized import path), while the one that explicitly gets the loopback IP succeeds. Which version are you using? (run 'go version') go version devel +664c8763de42 Tue Oct 01 11:24:24 2013 +1000 linux/amd64 This also breaks imports from file-system paths, ie > go get shared/go/foo.git Even though it works with a dot in the base name: > go get -x shared.dot/go/foo.git ... git clone shared.dot/foo/foo /home/$USER/Source/go/src/shared.dot/foo/foo.git (Go get clearly tries to fetch from the file-system too, where having a dot in the path isn't all that usual.)The text was updated successfully, but these errors were encountered: