Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/ssa: TestDominatorOrder failures #65183

Closed
gopherbot opened this issue Jan 19, 2024 · 4 comments
Closed

x/tools/go/ssa: TestDominatorOrder failures #65183

gopherbot opened this issue Jan 19, 2024 · 4 comments
Assignees
@adonovan
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
default <- pkg == "golang.org/x/tools/go/ssa" && test == "TestDominatorOrder"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestDominatorOrder (0.03s)
panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0

goroutine 1683 [running]:
testing.tRunner.func1.2({0xf5ca9060, 0xcce88370})
	/workdir/go/src/testing/testing.go:1526 +0x2c5
testing.tRunner.func1()
	/workdir/go/src/testing/testing.go:1529 +0x4dd
panic({0xf5ca9060, 0xcce88370})
	/workdir/go/src/runtime/panic.go:890 +0x262
golang.org/x/tools/go/ssa_test.TestDominatorOrder(0xccfbaf00)
	/workdir/gopath/src/golang.org/x/tools/go/ssa/dom_test.go:46 +0x6a1
testing.tRunner(0xccfbaf00, 0xf5cc4750)
	/workdir/go/src/testing/testing.go:1576 +0x150
created by testing.(*T).Run
	/workdir/go/src/testing/testing.go:1629 +0x46f
exitcode=2

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 19, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/go/ssa" && test == "TestDominatorOrder"
2024-01-19 23:15 android-386-emu tools@e1555a36 go@a95136a8 x/tools/go/ssa.TestDominatorOrder (log) 
--- FAIL: TestDominatorOrder (0.03s)
panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0

goroutine 1683 [running]:
testing.tRunner.func1.2({0xf5ca9060, 0xcce88370})
	/workdir/go/src/testing/testing.go:1526 +0x2c5
testing.tRunner.func1()
	/workdir/go/src/testing/testing.go:1529 +0x4dd
panic({0xf5ca9060, 0xcce88370})
	/workdir/go/src/runtime/panic.go:890 +0x262
golang.org/x/tools/go/ssa_test.TestDominatorOrder(0xccfbaf00)
	/workdir/gopath/src/golang.org/x/tools/go/ssa/dom_test.go:46 +0x6a1
testing.tRunner(0xccfbaf00, 0xf5cc4750)
	/workdir/go/src/testing/testing.go:1576 +0x150
created by testing.(*T).Run
	/workdir/go/src/testing/testing.go:1629 +0x46f
exitcode=2
2024-01-19 23:15 android-amd64-emu tools@e1555a36 go@a95136a8 x/tools/go/ssa.TestDominatorOrder (log) 
--- FAIL: TestDominatorOrder (0.02s)
panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0

goroutine 1655 [running]:
testing.tRunner.func1.2({0x7ec4a9364e80, 0xc0000288d0})
	/workdir/go/src/testing/testing.go:1526 +0x24e
testing.tRunner.func1()
	/workdir/go/src/testing/testing.go:1529 +0x39f
panic({0x7ec4a9364e80, 0xc0000288d0})
	/workdir/go/src/runtime/panic.go:884 +0x213
golang.org/x/tools/go/ssa_test.TestDominatorOrder(0xc00035d380)
	/workdir/gopath/src/golang.org/x/tools/go/ssa/dom_test.go:46 +0x571
testing.tRunner(0xc00035d380, 0x7ec4a9384ca0)
	/workdir/go/src/testing/testing.go:1576 +0x10b
created by testing.(*T).Run
	/workdir/go/src/testing/testing.go:1629 +0x3ea
exitcode=2

— watchflakes

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jan 19, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jan 19, 2024
@findleyr
Copy link
Contributor

This is a new test added in https://go.dev/cl/557055. Assigning to @adonovan.

CC @timothy-king

@gopherbot
Copy link
Author

Change https://go.dev/cl/557395 mentions this issue: go/ssa: suppress go/packages-based test on android

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/go/ssa" && test == "TestDominatorOrder"
2024-01-22 17:11 android-386-emu tools@a987ef7a go@a95136a8 x/tools/go/ssa.TestDominatorOrder (log) 
--- FAIL: TestDominatorOrder (0.04s)
panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0

goroutine 1669 [running]:
testing.tRunner.func1.2({0xea222060, 0xc12d6db0})
	/workdir/go/src/testing/testing.go:1526 +0x2c5
testing.tRunner.func1()
	/workdir/go/src/testing/testing.go:1529 +0x4dd
panic({0xea222060, 0xc12d6db0})
	/workdir/go/src/runtime/panic.go:890 +0x262
golang.org/x/tools/go/ssa_test.TestDominatorOrder(0xc13145a0)
	/workdir/gopath/src/golang.org/x/tools/go/ssa/dom_test.go:46 +0x6a1
testing.tRunner(0xc13145a0, 0xea23d750)
	/workdir/go/src/testing/testing.go:1576 +0x150
created by testing.(*T).Run
	/workdir/go/src/testing/testing.go:1629 +0x46f
exitcode=2
2024-01-22 17:11 android-amd64-emu tools@a987ef7a go@a95136a8 x/tools/go/ssa.TestDominatorOrder (log) 
--- FAIL: TestDominatorOrder (0.03s)
panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0

goroutine 1686 [running]:
testing.tRunner.func1.2({0x78cba05e4e80, 0xc0001304e0})
	/workdir/go/src/testing/testing.go:1526 +0x24e
testing.tRunner.func1()
	/workdir/go/src/testing/testing.go:1529 +0x39f
panic({0x78cba05e4e80, 0xc0001304e0})
	/workdir/go/src/runtime/panic.go:884 +0x213
golang.org/x/tools/go/ssa_test.TestDominatorOrder(0xc00021f860)
	/workdir/gopath/src/golang.org/x/tools/go/ssa/dom_test.go:46 +0x571
testing.tRunner(0xc00021f860, 0x78cba0604ca0)
	/workdir/go/src/testing/testing.go:1576 +0x10b
created by testing.(*T).Run
	/workdir/go/src/testing/testing.go:1629 +0x3ea
exitcode=2

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonovan adonovan

Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@timothy-king @adonovan @gopherbot @findleyr