Skip to content

x/telemetry/internal/counter: TestRotate failures #65182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Jan 19, 2024 · 4 comments
Closed

x/telemetry/internal/counter: TestRotate failures #65182

gopherbot opened this issue Jan 19, 2024 · 4 comments
Assignees
@pjweinb
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/telemetry/internal/counter" && test == "TestRotate"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestRotate (0.01s)
    rotate_test.go:138: GOOS windows GOARCH amd64
    rotate_test.go:179: modified = 244055600, want 238175500

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 19, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/telemetry/internal/counter" && test == "TestRotate"
2024-01-16 21:27 windows-amd64-2016 telemetry@88e2d1c7 go@f19f31f2 x/telemetry/internal/counter.TestRotate (log) 
--- FAIL: TestRotate (0.01s)
    rotate_test.go:138: GOOS windows GOARCH amd64
    rotate_test.go:179: modified = 244055600, want 238175500

— watchflakes

@gopherbot gopherbot added the telemetry x/telemetry issues label Jan 19, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jan 19, 2024
@findleyr
Copy link
Member

CC @pjweinb, since this test changed recently.

@pjweinb
Copy link

pjweinb commented Jan 24, 2024

This may be related to newly filed github.com//issues/65255, which happened when trying to reproduce the failure.

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/559498 mentions this issue: internal/counter: fix flaky test

@golang golang locked and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjweinb pjweinb

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Projects
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@pjweinb @gopherbot @findleyr