x/tools/gopls: "source" and "code" in publishDiagnostics
are reversed
#65168
Labels
FrozenDueToAge
gopls/analysis
Issues related to running analysis in gopls
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
During the investigation of #65167, I noticed that the source/code fields look strange.
Shouldn't they be reversed?
Moreover, it looks like VS Code uses "code" as the identifiers of diagnostics. I am guessing this is used to dedup diagnostics, which is why we saw the editor didn't send code action for SA1006 in #65167.https://code.visualstudio.com/api/references/vscode-api#Diagnostic
EDIT: the duplication based on
code
-only was from misunderstanding. It looks like vscode does not dedup. :-)The text was updated successfully, but these errors were encountered: