x/telemetry/godev: set up autodeployment and push test #65165
Comments
findleyr
changed the title
|
I think we had discussed a deployment trigger. Let's set that up, along with a push test. |
|
Change https://go.dev/cl/556860 mentions this issue: |
gopherbot
pushed a commit
to golang/telemetry
that referenced
this issue
Jan 19, 2024
Add a basic test to check responses for the telemetry frontend. This test can also be used as a push test against the dev telemetry instance when deploying. For golang/go#65165 Change-Id: Ic823663bac98845e6d95e4af3e799317fcd380ce Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/556860 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
|
Change https://go.dev/cl/557855 mentions this issue: |
gopherbot
pushed a commit
to golang/telemetry
that referenced
this issue
Jan 23, 2024
Add a google cloud build configuration to deploy to dev, run a push test, and deploy to prod. For golang/go#65165 Change-Id: If6ccc39262b325c7cefe34242fb582e1ce2ce879 Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/557855 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
|
Change https://go.dev/cl/558438 mentions this issue: |
gopherbot
pushed a commit
to golang/telemetry
that referenced
this issue
Jan 25, 2024
For golang/go#65165 Change-Id: I18f64106defb521baf0ea34f7549af0561ab0bb6 Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/558438 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Robert Findley <rfindley@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
|
Change https://go.dev/cl/558439 mentions this issue: |
gopherbot
pushed a commit
to golang/telemetry
that referenced
this issue
Jan 25, 2024
For golang/go#65165 Change-Id: If5c49936a0123063aecc16988ba9ebd1b65902af Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/558439 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
|
This is now done: the telemetry frontend is auto-deployed to production, following a push test, on any merge to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since Jan, my telemetry uploads were all rejected with 400 (Bad Request)
Looking at the server, I noticed many upload reports are indeed rejected with errors like
Looking into the codebase further,
the server program reads configuration from a file (./config/config.json)
that is copied when the container was built https://github.com/golang/telemetry/blob/88e2d1c7f9a20e3476dd2cca5112e374c8911eed/godev/cmd/telemetrygodev/Dockerfile#L55
And, this configuration is being used until the next production release
https://github.com/golang/telemetry/blob/88e2d1c7f9a20e3476dd2cca5112e374c8911eed/godev/cmd/telemetrygodev/main.go#L40
https://github.com/golang/telemetry/blob/88e2d1c7f9a20e3476dd2cca5112e374c8911eed/godev/cmd/telemetrygodev/main.go#L51
I think the workers also share this setup.
It looks like the production service wasn't rebuilt/restarted for a while.
cc @findleyr @pjweinb
The text was updated successfully, but these errors were encountered: