Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/trace: trace.Logf messages missing from timeline #65153

Closed
prattmic opened this issue Jan 18, 2024 · 6 comments
Closed

cmd/trace: trace.Logf messages missing from timeline #65153

prattmic opened this issue Jan 18, 2024 · 6 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.22

Comments

@prattmic
Copy link
Member

In the new execution tracer, cmd/trace is missing handling of trace.Logf messages and thus simply omits them from the timeline.

cc @mknyszek
@prattmic prattmic added this to the Go1.22 milestone Jan 18, 2024
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jan 18, 2024
@SoulPancake
Copy link

Can I work on this? @prattmic

@prattmic
Copy link
Member Author

Thanks for offering! I would normally say I'd love your help, but since this is a regression, it should probably be a release blocker for 1.22 (I forgot to mark that this morning) and thus fixed ASAP. Thus it is probably best for either myself or @mknyszek to take.

@cagedmantis cagedmantis added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 19, 2024
@gopherbot
Copy link

Change https://go.dev/cl/557175 mentions this issue: cmd/trace/v2: emit user log annotations in all views

@dmitshur
Copy link
Contributor

Reopening to track the fix landing on release-branch.go1.22. I commented on the CL.

@dmitshur dmitshur reopened this Jan 22, 2024
@gopherbot
Copy link

Change https://go.dev/cl/557817 mentions this issue: [release-branch.go1.22] cmd/trace/v2: emit user log annotations in all views

gopherbot pushed a commit that referenced this issue Jan 23, 2024
@mknyszek @gopherbot
[release-branch.go1.22] cmd/trace/v2: emit user log annotations in al…
817009d 
…l views

This was an oversight in porting over cmd/trace to the new trace format
and API.

Fixes #65153.

Change-Id: I883d302f95956fcc9abb60aa53165acb6d099d67
Reviewed-on: https://go-review.googlesource.com/c/go/+/557175
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
(cherry picked from commit 7cb98c1)
Reviewed-on: https://go-review.googlesource.com/c/go/+/557817
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
@cherrymui
Copy link
Member

Done by submitting the cherrypick CL.

ezz-no pushed a commit to ezz-no/go-ezzno that referenced this issue Feb 18, 2024
@mknyszek @ezz-no
cmd/trace/v2: emit user log annotations in all views
2712751 
This was an oversight in porting over cmd/trace to the new trace format
and API.

Fixes golang#65153.

Change-Id: I883d302f95956fcc9abb60aa53165acb6d099d67
Reviewed-on: https://go-review.googlesource.com/c/go/+/557175
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
Release Status & Release Blockers
Status: Done
Milestone
Go1.22
Development

No branches or pull requests
6 participants
@cagedmantis @prattmic @dmitshur @gopherbot @cherrymui @SoulPancake