Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: cannot start trybots on CLs from unprivileged users with (unapproved) dependencies #65140

Open
prattmic opened this issue Jan 17, 2024 · 0 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@prattmic
Copy link
Member

In LUCI, if a CL is owned by an unprivileged user [1], and has a dependency (parent CL) which is also owned by an unprivileged user (usually the same user) and not yet submittable, then LUCI will not allow testing with Commit-Queue+1, regardless of the privileges of the user requesting testing.

For example, https://go.dev/cl/556335 depends on https://go.dev/cl/555996.

LUCI responds with something like:

"CV cannot start a Run because of the following dependencies. They must be submittable (please check the submit requirement) because their owners are not committers or dry-runners. Alternatively, you can ask the owner of this CL to trigger a dry-run.

This is an intentional limitation in LUCI intended to guard against a reviewer failing to notice malicious code in the parent CL. Still, it is a frustrating roadblock in development. We may want to loosen this to something like allowing testing if the dependencies also had a valid Commit-Queue+1.

[1] i.e., not Approver or may-start-trybots

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jan 17, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jan 17, 2024
@cagedmantis cagedmantis added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Status: Planned
Development

No branches or pull requests

3 participants