Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html/template: the documentation contains a link to the end-of-life RawGit service #65044

Open
jub0bs opened this issue Jan 9, 2024 · 4 comments
Open

html/template: the documentation contains a link to the end-of-life RawGit service #65044

jub0bs opened this issue Jan 9, 2024 · 4 comments
Labels
Documentation FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Backlog

Comments

@jub0bs
Copy link

jub0bs commented Jan 9, 2024 •
edited

Go version

1.21.5

What did you do?

Inspect

go/src/html/template/doc.go

Line 213 in 59ecebf

https://rawgit.com/mikesamuel/sanitized-jquery-templates/trunk/safetemplate.html#problem_definition defines "safe" as used by this package.

What did you see happen?

https://rawgit.com/mikesamuel/sanitized-jquery-templates/trunk/safetemplate.html#problem_definition defines "safe" as used by this package.

What did you expect to see?

The documentation should no longer rely on RawGit: that project reached end-of-life status as far back as 2018 and its domain name may lapse at any moment.

An alternative that other packages of the standard library rely on: the Wayback Machine.

https://web.archive.org/web/20160501113828/http://js-quasis-libraries-and-repl.googlecode.com/svn/trunk/safetemplate.html#problem_definition defines "safe" as used by this package.

Related: #46469
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 9, 2024
@dmitshur dmitshur added this to the Backlog milestone Jan 9, 2024
@dmitshur
Copy link
Contributor

dmitshur commented Jan 9, 2024

Thanks for reporting.

CC @golang/security. Which alternative link would you prefer to use?

@rolandshoemaker
Copy link
Member

Using the wayback machine link seems like a reasonable solution.

@dmitshur dmitshur added the Suggested Issues that may be good for new contributors looking for work to do. label Jan 10, 2024
@gopherbot
Copy link

Change https://go.dev/cl/555815 mentions this issue: html/template: replace end-of-life link

@dmitshur dmitshur added the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Jan 15, 2024
@ianlancetaylor
Copy link
Contributor

@mikesamuel Is there an updated link that isn't on rawgit.com which is end of life? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@dmitshur @ianlancetaylor @rolandshoemaker @gopherbot @jub0bs