Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/analysis/unitchecker,slices: TestVetStdlib failing due to vet errors in panic tests [1.21 backport] #65023

Closed
gopherbot opened this issue Jan 8, 2024 · 2 comments
Closed

x/tools/go/analysis/unitchecker,slices: TestVetStdlib failing due to vet errors in panic tests [1.21 backport] #65023

gopherbot opened this issue Jan 8, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Go1.21.7

Comments

@gopherbot
Copy link

@dmitshur requested issue #64978 to be considered for backport to the next 1.21 minor release.

@gopherbot Please backport to Go 1.21. This is a test-only fix that'll fix longtest builders.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 8, 2024
@gopherbot gopherbot mentioned this issue Jan 8, 2024
Closed
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jan 8, 2024
@gopherbot gopherbot modified the milestones: Unreleased, Go1.21.6 Jan 8, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/554756 mentions this issue: [release-branch.go1.21] slices: explicitly discard results of some functions

@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. and removed Tools This label describes issues relating to any tools in the x/tools repository. labels Jan 8, 2024
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jan 8, 2024
@gopherbot gopherbot modified the milestones: Go1.21.6, Go1.21.7 Jan 9, 2024
@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Jan 10, 2024
gopherbot pushed a commit that referenced this issue Jan 10, 2024
@adonovan @gopherbot
[release-branch.go1.21] slices: explicitly discard results of some fu…
2540b14 
…nctions

This will otherwise trigger an "unusedresult" vet check.

For #64978.
Fixes #65023.
Fixes #60058.

Change-Id: Ie19aded0f808d394f389452c3ff7f3edc1ed710d
Reviewed-on: https://go-review.googlesource.com/c/go/+/554196
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 8088b6d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/554756
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
@gopherbot
Copy link
Author

Closed by merging 2540b14 to release-branch.go1.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Go1.21.7
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot