New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: remove concatstring{2,3,4,5} #65020
Labels
compiler/runtime
Issues related to the Go compiler and/or runtime.
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Performance
Milestone
Comments
lasiar
added a commit
to lasiar/go
that referenced
this issue
Jan 8, 2024
Functions runtime.concatstring{2,3,4,5} were added by commit: 24699fb to avoid using C varargs. But now these are not needed anymore. Refs golang#65020
lasiar
added a commit
to lasiar/go
that referenced
this issue
Jan 8, 2024
Functions runtime.concatstring{2,3,4,5} were added by commit: 24699fb to avoid using C varargs. But now these are not needed anymore. Refs golang#65020
lasiar
added a commit
to lasiar/go
that referenced
this issue
Jan 8, 2024
Functions runtime.concatstring{2,3,4,5} were added by commit: 24699fb to avoid using C varargs. But now these are not needed anymore. Refs golang#65020
lasiar
added a commit
to lasiar/go
that referenced
this issue
Jan 8, 2024
Functions runtime.concatstring{2,3,4,5} were added by commit: 24699fb to avoid using C varargs. But now these are not needed anymore. Fixes golang#65020
Change https://go.dev/cl/554835 mentions this issue: |
Taking out of proposal process, no API changes. |
randall77
changed the title
proposal: runtime: remove concatstring{2,3,4,5}
runtime: remove concatstring{2,3,4,5}
Jan 8, 2024
dmitshur
added
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
compiler/runtime
Issues related to the Go compiler and/or runtime.
labels
Jan 9, 2024
lasiar
added a commit
to lasiar/go
that referenced
this issue
Jan 15, 2024
Functions runtime.concatstring{2,3,4,5} were added by commit: 24699fb to avoid using C varargs. But now these are not needed anymore. Fixes golang#65020
See #27801 though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compiler/runtime
Issues related to the Go compiler and/or runtime.
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Performance
Background
Functions
runtime.concatstring{2,3,4,5}
were added by commit: 24699fb to avoid using C varargs (accordingly written in c).After these functions have been replaced to Golang code by commit 61dca94, functions only calls
runtime.concatstrings()
and that is it.Proposal
Remove
runtime.concatstring{2,3,4,5}
and use onlyruntime.concatstrings(*tmpBuf, []string) string
.API changes
Nope
Benefits
Benchmark code
Result of benchmark
name old time/op new time/op delta Concat2-10 11.3ns ± 1% 10.6ns ± 0% -6.37% (p=0.000 n=18+17) Concat3-10 14.3ns ± 0% 13.6ns ± 3% -5.26% (p=0.000 n=18+20) Concat4-10 18.3ns ± 5% 17.7ns ± 3% -3.17% (p=0.000 n=18+20) Concat5-10 21.1ns ± 1% 20.6ns ± 0% -2.26% (p=0.000 n=18+18) Concat6-10 23.2ns ± 2% 23.3ns ± 0% ~ (p=0.084 n=18+19)
The Concat6 must show same result, because changes doesn't affect.
The text was updated successfully, but these errors were encountered: