Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/unix: TestDirent failures #65015

Closed
gopherbot opened this issue Jan 8, 2024 · 5 comments
Closed

x/sys/unix: TestDirent failures #65015

gopherbot opened this issue Jan 8, 2024 · 5 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@gopherbot
Copy link

gopherbot commented Jan 8, 2024 •
edited by bcmills 

#!watchflakes
post <- pkg == "golang.org/x/sys/unix" && test == "TestDirent" && `got \d+ names; expected 10`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestDirent (0.01s)
    dirent_test.go:31: tmpdir: /home/gopher/build/tmp/TestDirent17658839769333274243/001
    dirent_test.go:64: names: ["33333333333333"]
    dirent_test.go:67: got 1 names; expected 10

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. compiler/runtime Issues related to the Go compiler and/or runtime. labels Jan 8, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jan 8, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/sys/unix" && test == "TestDirent"
2023-12-01 17:42 linux-riscv64-jsing sys@5ff87d7b go@3f2bf706 x/sys/unix.TestDirent (log) 
--- FAIL: TestDirent (0.01s)
    dirent_test.go:31: tmpdir: /home/gopher/build/tmp/TestDirent17658839769333274243/001
    dirent_test.go:64: names: ["33333333333333"]
    dirent_test.go:67: got 1 names; expected 10

— watchflakes

@bcmills

This comment was marked as outdated.

Sign in to view
@bcmills bcmills added the arch-riscv Issues solely affecting the riscv64 architecture. label Jan 8, 2024
@bcmills
Copy link
Contributor

bcmills commented Jan 8, 2024

See previously:

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. help wanted and removed arch-riscv Issues solely affecting the riscv64 architecture. labels Jan 8, 2024
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 8, 2024
@bcmills
Copy link
Contributor

bcmills commented Jan 8, 2024

Looks like the test fix from https://go.dev/cl/376334 needs to be ported to x/sys.

@gopherbot
Copy link
Author

Change https://go.dev/cl/554875 mentions this issue: unix: in TestDirent, make as many ReadDirent calls as are needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot