Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/windows: support wsarecv error #65004

Closed
warent opened this issue Jan 8, 2024 · 3 comments
Closed

x/sys/windows: support wsarecv error #65004

warent opened this issue Jan 8, 2024 · 3 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unreleased

Comments

@warent
Copy link

warent commented Jan 8, 2024

Proposal Details

Windows has an OpError "wsarecv: An existing connection was forcibly closed by the remote host." Easily reproducible by connecting to a TCP server and force closing the client.

zerrors_windows.go is quite comprehensive but does not include this error.

Side note, I believe there is one for wsasend as well which may be considered for inclusion.
@warent warent added the Proposal label Jan 8, 2024
@gopherbot gopherbot added this to the Proposal milestone Jan 8, 2024
@ianlancetaylor
Copy link
Contributor

These days we would normally add an error like this to the golang.org/x/sys/windows package, which does not require a proposal. Is there a reason that this needs to be in the syscall package?

@ianlancetaylor ianlancetaylor changed the title proposal: syscall: support wsarecv error x/sys/windows: support wsarecv error Feb 6, 2024
@ianlancetaylor ianlancetaylor added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed Proposal labels Feb 6, 2024
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 6, 2024
@ianlancetaylor ianlancetaylor modified the milestones: Proposal, Unreleased Feb 6, 2024
@qmuntal
Copy link
Contributor

qmuntal commented Feb 22, 2024

These days we would normally add an error like this to the golang.org/x/sys/windows package, which does not require a proposal.

That error is already there: windows.WSAECONNRESET.

Is there a reason that this needs to be in the syscall package?

@warent we need this info to proceed with this issue. Thanks.

@qmuntal qmuntal added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. and removed help wanted labels Feb 22, 2024
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@gopherbot gopherbot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
Go Compiler / Runtime
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@ianlancetaylor @qmuntal @gopherbot @warent