Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/internal/test/integration/completion: TestUndownloadedModule failures #64981

Closed
gopherbot opened this issue Jan 5, 2024 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == "TestUndownloadedModule"

Issue created automatically to collect these failures.

Example (log):

goroutine profile: total 10
1 @ 0x10336b1 0x106b19d 0x11da0d1 0x11d9f05 0x11d69a6 0x18c8270 0x18c7dd6 0x11325df 0x1071c41
#	0x106b19c	runtime/pprof.runtime_goroutineProfileWithLabels+0x1c				/tmp/buildlet/go/src/runtime/mprof.go:844
#	0x11da0d0	runtime/pprof.writeRuntimeProfile+0xb0						/tmp/buildlet/go/src/runtime/pprof/pprof.go:734
#	0x11d9f04	runtime/pprof.writeGoroutine+0x44						/tmp/buildlet/go/src/runtime/pprof/pprof.go:694
#	0x11d69a5	runtime/pprof.(*Profile).WriteTo+0x145						/tmp/buildlet/go/src/runtime/pprof/pprof.go:329
#	0x18c826f	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:207
#	0x18c7dd5	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xc95	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:255
#	0x11325de	testing.tRunner+0xfe								/tmp/buildlet/go/src/testing/testing.go:1595

...
#	0x16fb1ce	golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).load+0xc6e			/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/load.go:136
#	0x1717b2c	golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).MetadataForFile+0x30c		/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/snapshot.go:796
#	0x179ac6d	golang.org/x/tools/gopls/internal/lsp/source.NarrowestMetadataForFile+0x4d		/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/source/snapshot.go:22
#	0x18768d8	golang.org/x/tools/gopls/internal/server.(*server).diagnoseChangedFiles+0x378		/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/server/diagnostics.go:266
#	0x1875f8b	golang.org/x/tools/gopls/internal/server.(*server).diagnoseSnapshot+0x32b		/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/server/diagnostics.go:200
#	0x1875ac9	golang.org/x/tools/gopls/internal/server.(*server).diagnoseChangedViews.func1+0xa9	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/server/diagnostics.go:135

--- FAIL: TestUndownloadedModule (1.99s)
    --- FAIL: TestUndownloadedModule/default (1.99s)
        runner.go:208: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /tmp/buildlet/tmp/gopls-test-3067158906/TestUndownloadedModule/default: directory not empty

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 5, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == "TestUndownloadedModule"
2024-01-05 21:50 darwin-amd64-12_0 tools@c9c95f97 go@d2cb1401 x/tools/gopls/internal/test/integration/completion.TestUndownloadedModule (log)
goroutine profile: total 10
1 @ 0x10336b1 0x106b19d 0x11da0d1 0x11d9f05 0x11d69a6 0x18c8270 0x18c7dd6 0x11325df 0x1071c41
#	0x106b19c	runtime/pprof.runtime_goroutineProfileWithLabels+0x1c				/tmp/buildlet/go/src/runtime/mprof.go:844
#	0x11da0d0	runtime/pprof.writeRuntimeProfile+0xb0						/tmp/buildlet/go/src/runtime/pprof/pprof.go:734
#	0x11d9f04	runtime/pprof.writeGoroutine+0x44						/tmp/buildlet/go/src/runtime/pprof/pprof.go:694
#	0x11d69a5	runtime/pprof.(*Profile).WriteTo+0x145						/tmp/buildlet/go/src/runtime/pprof/pprof.go:329
#	0x18c826f	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:207
#	0x18c7dd5	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xc95	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:255
#	0x11325de	testing.tRunner+0xfe								/tmp/buildlet/go/src/testing/testing.go:1595

...
#	0x16fb1ce	golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).load+0xc6e			/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/load.go:136
#	0x1717b2c	golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).MetadataForFile+0x30c		/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/snapshot.go:796
#	0x179ac6d	golang.org/x/tools/gopls/internal/lsp/source.NarrowestMetadataForFile+0x4d		/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/source/snapshot.go:22
#	0x18768d8	golang.org/x/tools/gopls/internal/server.(*server).diagnoseChangedFiles+0x378		/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/server/diagnostics.go:266
#	0x1875f8b	golang.org/x/tools/gopls/internal/server.(*server).diagnoseSnapshot+0x32b		/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/server/diagnostics.go:200
#	0x1875ac9	golang.org/x/tools/gopls/internal/server.(*server).diagnoseChangedViews.func1+0xa9	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/server/diagnostics.go:135

--- FAIL: TestUndownloadedModule (1.99s)
    --- FAIL: TestUndownloadedModule/default (1.99s)
        runner.go:208: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /tmp/buildlet/tmp/gopls-test-3067158906/TestUndownloadedModule/default: directory not empty

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 5, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jan 5, 2024
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.15.0 Jan 6, 2024
@findleyr
Copy link
Member

findleyr commented Jan 6, 2024

Dupe of #64971

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Archived in project
Development

No branches or pull requests

2 participants