Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: docs for go:wasmimport #64972

Closed
seankhliao opened this issue Jan 5, 2024 · 2 comments
Closed

cmd/compile: docs for go:wasmimport #64972

seankhliao opened this issue Jan 5, 2024 · 2 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. Documentation FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.22

Comments

@seankhliao
Copy link
Member

//go:wasmimport was added as part of #59149

Currently there are no docs for it anywhere outside of the proposal and a section on the wasi blog post

It should be listed in the package docs for cmd/compile https://pkg.go.dev/cmd/compile

cc @golang/wasm
@seankhliao seankhliao added Documentation NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Jan 5, 2024
@seankhliao seankhliao added this to the Go1.22 milestone Jan 5, 2024
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jan 5, 2024
@mauri870 mauri870 mentioned this issue Jan 6, 2024
Closed
@gopherbot
Copy link

Change https://go.dev/cl/554455 mentions this issue: cmd/compile: document go:wasmimport directive

@eliben
Copy link
Member

eliben commented Jan 9, 2024

@johanbrandhorst @Pryz @evanphx @achille-roussel

@dmitshur dmitshur added the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Jan 10, 2024
ezz-no pushed a commit to ezz-no/go-ezzno that referenced this issue Feb 18, 2024
@mauri870 @ezz-no
cmd/compile: document go:wasmimport directive
14408ad 
Fixes golang#64972

Change-Id: I784a8728afbdef9736681d56f0a79c82a00609d6
GitHub-Last-Rev: bf158db
GitHub-Pull-Request: golang#64991
Reviewed-on: https://go-review.googlesource.com/c/go/+/554455
Reviewed-by: Achille Roussel <achille.roussel@gmail.com>
Reviewed-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Austin Clements <austin@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. Documentation FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
Release Status & Release Blockers
Status: Done
Milestone
Go1.22
Development

Successfully merging a pull request may close this issue.

cmd/compile: document go:wasmimport directive mauri870/go
4 participants
@eliben @dmitshur @gopherbot @seankhliao