Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools: publish GitHub releases for tools #64886

Closed
katexochen opened this issue Dec 28, 2023 · 4 comments
Closed

x/tools: publish GitHub releases for tools #64886

katexochen opened this issue Dec 28, 2023 · 4 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@katexochen
Copy link

Currently, only new gopls versions are published as GitHub release under https://github.com/golang/tools/releases. The tool versions are only tagged but not published.
Would it be possible to also get GitHub releases for those versions? Automatic detection of new releases is much better supported on GitHub than for tags, e.g., you cannot watch new tags on a repo to get notification. It would also help with downstream packaging tools/automation.
Thanks and keep GOing! :)
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Dec 28, 2023
@gopherbot gopherbot added this to the Unreleased milestone Dec 28, 2023
@dr2chase
Copy link
Contributor

@golang/tools-team

@dr2chase dr2chase added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 28, 2023
@findleyr
Copy link
Contributor

CC @golang/release, since this argument could apply to any subrepo, not just tools.

I defer to the release team, but suspect we won't want to do this. Gopls release notes are manually curated and published specifically so that we can explain what changed. x/tools releases are arbitrary, and so the release notes would be pretty meaningless. Therefore the only purpose of creating a release would be to feed automation, as you note. That doesn't seem worth maintaining an extra piece of automation on our side.

@seankhliao
Copy link
Member

see also #13497 #15966 #40768 #45185

@findleyr
Copy link
Contributor

Thanks @seankhliao. Sounds like we are not opposed to this after all. Closing as a dupe of #15966.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@dr2chase @gopherbot @seankhliao @katexochen @findleyr