Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: panic in inliner (reported by telemetry) #64836

Closed
adonovan opened this issue Dec 21, 2023 · 2 comments
Closed

x/tools/gopls: panic in inliner (reported by telemetry) #64836

adonovan opened this issue Dec 21, 2023 · 2 comments
Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@adonovan
Copy link
Member

adonovan commented Dec 21, 2023 •
edited

This stack r1B57A, bMdohA was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Errorf:2
golang.org/x/tools/gopls/internal/lsp/source.inlineCall.func2:2
runtime.gopanic:88
runtime.goPanicIndex:2
golang.org/x/tools/internal/refactor/inline.substitute:10
golang.org/x/tools/internal/refactor/inline.inline:339
golang.org/x/tools/internal/refactor/inline.Inline:15
golang.org/x/tools/gopls/internal/lsp/source.inlineCall:64
golang.org/x/tools/gopls/internal/lsp/source.ApplyFix:5
golang.org/x/tools/gopls/internal/lsp.(*commandHandler).ApplyFix.func1:1
golang.org/x/tools/gopls/internal/lsp.(*commandHandler).run.func1:2
golang.org/x/tools/gopls/internal/lsp.(*commandHandler).run:72
golang.org/x/tools/gopls/internal/lsp.(*commandHandler).ApplyFix:1
golang.org/x/tools/gopls/internal/lsp/command.Dispatch:25
golang.org/x/tools/gopls/internal/lsp.(*Server).executeCommand:19

golang.org/x/tools/gopls@v0.14.2 go1.21.3 linux/amd64 (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

Dups: O68kdw
@adonovan adonovan added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. gopls/telemetry-wins labels Dec 21, 2023
@gopherbot gopherbot added this to the Unreleased milestone Dec 21, 2023
@adonovan
Copy link
Member Author

This looks like a related failure to #64558: argument/params mismatch in ill-typed code. The fix is the same: https://go.dev/cl/548736

@adonovan
Copy link
Member Author

This stack O68kdw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Errorf:2
golang.org/x/tools/gopls/internal/lsp/source.inlineCall.func2:2
runtime.gopanic:50
runtime.goPanicIndex:2
golang.org/x/tools/internal/refactor/inline.substitute:10
golang.org/x/tools/internal/refactor/inline.inline:339
golang.org/x/tools/internal/refactor/inline.Inline:15
golang.org/x/tools/gopls/internal/lsp/source.inlineCall:64
golang.org/x/tools/gopls/internal/lsp/source.ApplyFix:5
golang.org/x/tools/gopls/internal/lsp.(*commandHandler).ApplyFix.func1:1
golang.org/x/tools/gopls/internal/lsp.(*commandHandler).run.func1:2
golang.org/x/tools/gopls/internal/lsp.(*commandHandler).run:72
golang.org/x/tools/gopls/internal/lsp.(*commandHandler).ApplyFix:1
golang.org/x/tools/gopls/internal/lsp/command.Dispatch:25
golang.org/x/tools/gopls/internal/lsp.(*Server).executeCommand:19

golang.org/x/tools/gopls@v0.14.2 go1.22.0 darwin/arm64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@adonovan @gopherbot