Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/internal/test/integration/completion: TestCompleteAllFields failures #64787

Closed
gopherbot opened this issue Dec 18, 2023 · 3 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Dec 18, 2023

Issue created automatically to collect these failures.

Example (log):

goroutine profile: total 11
1 @ 0x5dc8851 0x5e0483d 0x5f7ed71 0x5f7eba5 0x5f7b9cb 0x6687e70 0x66879f4 0x5ed055b 0x5e0b441
#	0x5e0483c	runtime/pprof.runtime_goroutineProfileWithLabels+0x1c				/tmp/buildlet/go/src/runtime/mprof.go:1079
#	0x5f7ed70	runtime/pprof.writeRuntimeProfile+0xb0						/tmp/buildlet/go/src/runtime/pprof/pprof.go:774
#	0x5f7eba4	runtime/pprof.writeGoroutine+0x44						/tmp/buildlet/go/src/runtime/pprof/pprof.go:734
#	0x5f7b9ca	runtime/pprof.(*Profile).WriteTo+0x14a						/tmp/buildlet/go/src/runtime/pprof/pprof.go:369
#	0x6687e6f	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:207
#	0x66879f3	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xc53	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:255
#	0x5ed055a	testing.tRunner+0xfa								/tmp/buildlet/go/src/testing/testing.go:1689

...
#	0x649e685	golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck+0x6e5	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/analysis.go:1031
#	0x649d3d7	golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).run+0x1d7		/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/analysis.go:810
#	0x649bd45	golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).runCached+0x125	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/analysis.go:672
#	0x6499ea9	golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).Analyze.func6.1+0xc9	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/analysis.go:398
#	0x6180135	golang.org/x/sync/errgroup.(*Group).Go.func1+0x55				/tmp/buildlet/gopath/pkg/mod/golang.org/x/sync@v0.5.0/errgroup/errgroup.go:75

--- FAIL: TestCompleteAllFields (11.61s)
    --- FAIL: TestCompleteAllFields/default (11.56s)
        runner.go:208: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: go command failed (stdout: ) (stderr: go: unlinkat /tmp/buildlet/tmp/gopls-test-1801426690/TestCompleteAllFields/default/gopath/pkg/mod/cache: directory not empty
            ): exit status 1; removing files: <nil>

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 18, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == "TestCompleteAllFields"
2023-12-18 18:59 darwin-amd64-nocgo tools@83bceaf2 go@8e3930f2 x/tools/gopls/internal/test/integration/completion.TestCompleteAllFields (log)
goroutine profile: total 11
1 @ 0x5dc8851 0x5e0483d 0x5f7ed71 0x5f7eba5 0x5f7b9cb 0x6687e70 0x66879f4 0x5ed055b 0x5e0b441
#	0x5e0483c	runtime/pprof.runtime_goroutineProfileWithLabels+0x1c				/tmp/buildlet/go/src/runtime/mprof.go:1079
#	0x5f7ed70	runtime/pprof.writeRuntimeProfile+0xb0						/tmp/buildlet/go/src/runtime/pprof/pprof.go:774
#	0x5f7eba4	runtime/pprof.writeGoroutine+0x44						/tmp/buildlet/go/src/runtime/pprof/pprof.go:734
#	0x5f7b9ca	runtime/pprof.(*Profile).WriteTo+0x14a						/tmp/buildlet/go/src/runtime/pprof/pprof.go:369
#	0x6687e6f	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:207
#	0x66879f3	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xc53	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:255
#	0x5ed055a	testing.tRunner+0xfa								/tmp/buildlet/go/src/testing/testing.go:1689

...
#	0x649e685	golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck+0x6e5	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/analysis.go:1031
#	0x649d3d7	golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).run+0x1d7		/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/analysis.go:810
#	0x649bd45	golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).runCached+0x125	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/analysis.go:672
#	0x6499ea9	golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).Analyze.func6.1+0xc9	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/analysis.go:398
#	0x6180135	golang.org/x/sync/errgroup.(*Group).Go.func1+0x55				/tmp/buildlet/gopath/pkg/mod/golang.org/x/sync@v0.5.0/errgroup/errgroup.go:75

--- FAIL: TestCompleteAllFields (11.61s)
    --- FAIL: TestCompleteAllFields/default (11.56s)
        runner.go:208: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: go command failed (stdout: ) (stderr: go: unlinkat /tmp/buildlet/tmp/gopls-test-1801426690/TestCompleteAllFields/default/gopath/pkg/mod/cache: directory not empty
            ): exit status 1; removing files: <nil>

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 18, 2023
@gopherbot gopherbot added this to the Unreleased milestone Dec 18, 2023
@suzmue suzmue modified the milestones: Unreleased, gopls/v0.15.0 Dec 19, 2023
@findleyr
Copy link
Member

findleyr commented Jan 6, 2024

Dupe of #64971

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2024
@gopherbot
Copy link
Contributor Author

Sorry, but I can't find a watchflakes script at the start of the issue description.
See https://go.dev/wiki/Watchflakes for details.

watchflakes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants