-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls/internal/cmd: TestFix failures #64765
Comments
Found new dashboard test flakes for:
2023-12-15 21:59 linux-ppc64le-buildlet tools@4d2b6e1d go@bbab863a x/tools/gopls/internal/cmd.TestFix (log)
|
May be related to my change to diagnostic logic. Let's see. |
Found new dashboard test flakes for:
2023-12-18 20:56 linux-ppc64-sid-power10 tools@ee47fd47 go@52dbffea x/tools/gopls/internal/cmd.TestFix (log)
|
Found new dashboard test flakes for:
2023-12-19 22:22 netbsd-arm64-bsiegert tools@160631f7 go@8cb86b5f x/tools/gopls/internal/cmd.TestFix (log)
|
Found new dashboard test flakes for:
2023-12-26 17:53 freebsd-arm64-dmgk tools@025ebe62 go@bbab863a x/tools/gopls/internal/cmd.TestFix (log)
|
Found new dashboard test flakes for:
2023-12-31 00:29 windows-amd64-race tools@baf6fd25 go@b25f5558 x/tools/gopls/internal/cmd.TestFix (log)
|
Found new dashboard test flakes for:
2024-01-03 10:09 linux-arm-aws tools@5e6f314f go@8cb86b5f x/tools/gopls/internal/cmd.TestFix (log)
|
Found new dashboard test flakes for:
2024-01-03 12:29 windows-amd64-longtest tools@a863a4fc go@15dcdeb5 x/tools/gopls/internal/cmd.TestFix (log)
|
Found new dashboard test flakes for:
2024-01-03 12:29 linux-amd64-wsl tools@a863a4fc go@9e4abed3 x/tools/gopls/internal/cmd.TestFix (log)
|
Found new dashboard test flakes for:
2024-01-05 14:41 netbsd-386-9_3 tools@2e53332c go@d2cb1401 x/tools/gopls/internal/cmd.TestFix (log)
|
Found new dashboard test flakes for:
2024-01-08 23:16 dragonfly-amd64-622 tools@c95fa0ff go@821f9410 x/tools/gopls/internal/cmd.TestFix (log)
|
Looked into this briefly, but have to go for the day. Found the bug, it's a real race: Like this: we open the file, and then there's a race between the fast-path diagnostics (which don't include analysis) and the result of If we just awaited the diagnostics, similarly to how we await them in regtests, there would be no race and we could delete the |
Found new dashboard test flakes for:
2024-01-12 22:43 linux-ppc64-sid-buildlet tools@9164f2ae go@7abeefd2 x/tools/gopls/internal/cmd.TestFix (log)
|
Change https://go.dev/cl/556475 mentions this issue: |
Found new dashboard test flakes for:
2024-01-17 18:13 windows-arm64-11 tools@d5171129 go@a95136a8 x/tools/gopls/internal/cmd.TestFix (log)
|
Found new dashboard test flakes for:
2024-01-12 21:33 x_tools-go1.21-windows-386 tools@54cf5bc0 release-branch.go1.21@2540b143 x/tools/gopls/internal/cmd.TestFix (log)
|
Found new dashboard test flakes for:
2024-01-08 18:41 x_tools-go1.20-darwin-amd64_14 tools@25a0e9d3 release-branch.go1.20@5c38c049 x/tools/gopls/internal/cmd.TestFix (log)
|
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: