Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: use RelativePatterns for file watching if RelativePatternSupport is available #64763

Closed
findleyr opened this issue Dec 15, 2023 · 2 comments
Closed

x/tools/gopls: use RelativePatterns for file watching if RelativePatternSupport is available #64763

findleyr opened this issue Dec 15, 2023 · 2 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.15.0

Comments

@findleyr
Copy link
Contributor

In order to fix problems with Windows paths, we should use RelativePatterns if they are supported:
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#relativePattern

Because these patterns allow specifying a directory URI, they are a better solution for watching absolute directories, and don't suffer from windows drive casing issues.

See microsoft/vscode#104387 for more background.
@findleyr findleyr added this to the gopls/v0.15.0 milestone Dec 15, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 15, 2023
@findleyr
Copy link
Contributor Author

This is definitely necessary: I discovered that e.g. absolute patterns do not work in coc.nvim.

@findleyr findleyr self-assigned this Jan 17, 2024
@gopherbot
Copy link

Change https://go.dev/cl/557499 mentions this issue: gopls: use relative watched file patterns if supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.15.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr