Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: watch replaced directories #64762

Closed
findleyr opened this issue Dec 15, 2023 · 1 comment
Closed

x/tools/gopls: watch replaced directories #64762

findleyr opened this issue Dec 15, 2023 · 1 comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.15.0

Comments

@findleyr
Copy link
Contributor

At some point in the past, I'm pretty sure gopls registered file watchers for directories that were explicitly replaced via go.mod replace directives. However, this logic was reverted at some point, most likely while adding support for go.work files.

The rationale for watching replaced directories still makes sense to me, and so we should add it back, with tests.
@findleyr findleyr added this to the gopls/v0.15.0 milestone Dec 15, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 15, 2023
@gopherbot
Copy link

Change https://go.dev/cl/562680 mentions this issue: gopls/internal/cache: treat local replaces as workspace modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.15.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr