Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gomote: token has been expired or revoked #64748

Closed
cuonglm opened this issue Dec 15, 2023 · 6 comments
Closed

x/build/cmd/gomote: token has been expired or revoked #64748

cuonglm opened this issue Dec 15, 2023 · 6 comments
Assignees
@cagedmantis
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@cuonglm
Copy link
Member

cuonglm commented Dec 15, 2023 •
edited
Loading

Go version

N/A

What operating system and processor architecture are you using (go env)?

N/A

What did you do?

▶ gomote create linux-arm

What did you expect to see?

gomote create linux-arm runs ok.

What did you see instead?

▶ gomote create linux-arm
dialing the server=build.golang.org:443 failed with: IAP token exchange failed: status 400 Bad Request, body "{\n  \"error\": \"invalid_grant\",\n  \"error_description\": \"Token has been expired or revoked.\"\n}
@cuonglm cuonglm mentioned this issue Dec 15, 2023
Closed
@cagedmantis cagedmantis added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 15, 2023
@cagedmantis cagedmantis changed the title gomote: Token has been expired or revoked cmd/gomote: Token has been expired or revoked Dec 15, 2023
@cagedmantis cagedmantis changed the title cmd/gomote: Token has been expired or revoked cmd/gomote: token has been expired or revoked Dec 15, 2023
@cagedmantis cagedmantis added this to the Backlog milestone Dec 15, 2023
@cagedmantis cagedmantis self-assigned this Dec 15, 2023
@cagedmantis
Copy link
Contributor

We need to add the ability to refresh the authentication tokens. For now, you can work around this by removing the file located at os.UserConfigDir() + gomote/iap-refresh-tv-token and attempting another gomote action. You should be able to reauthenticate.

@cagedmantis
Copy link
Contributor

@cuonglm Did the suggested action resolve your issue?

@cuonglm
Copy link
Member Author

cuonglm commented Jan 3, 2024

@cuonglm Did the suggested action resolve your issue?

Sorry for late response, just back from the holidays.

It works for me.

Thank you.

@cuonglm cuonglm closed this as completed Jan 3, 2024
@cuonglm cuonglm reopened this Jan 3, 2024
@cagedmantis
Copy link
Contributor

@cuonglm No worries. I'm also just getting back from the holidays. Thanks.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/554056 mentions this issue: internal/iapclient: check for invalid token

gopherbot pushed a commit to golang/build that referenced this issue Jan 4, 2024
@cagedmantis @gopherbot
internal/iapclient: check for invalid token
e98483c 
This change adds a validation check for cached tokens. If the token
is invalid, then it will trigger a new login.

For golang/go#64748

Change-Id: I662dc0716a31bfe8e2b068606bc1e34c837269f2
Reviewed-on: https://go-review.googlesource.com/c/build/+/554056
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@cagedmantis
Copy link
Contributor

I suspect this issue has been fixed by the CL. I'm going to some time to confirm that it doesn't happen again.

@dmitshur dmitshur modified the milestones: Backlog, Unreleased Jun 13, 2024
@dmitshur dmitshur changed the title cmd/gomote: token has been expired or revoked x/build/cmd/gomote: token has been expired or revoked Jun 13, 2024
@dmitshur dmitshur added the Builders x/build issues (builders, bots, dashboards) label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagedmantis cagedmantis

Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@cagedmantis @dmitshur @cuonglm @gopherbot