Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cloudfns/{sendwikidiff,wikiwebhook}: remove #64730

Closed
dmitshur opened this issue Dec 15, 2023 · 3 comments
Closed

x/build/cloudfns/{sendwikidiff,wikiwebhook}: remove #64730

dmitshur opened this issue Dec 15, 2023 · 3 comments
Assignees
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Dec 15, 2023

Now that the Go wiki content has moved to Gerrit (#61940), the cloud functions we've setup to mail wiki edits to golang-wikichanges are most likely obsolete.

In particular, this mailing list was created because there was no other way to subscribe to wiki changes, and there was no review process at all. Neither of those are true now: it's possible to subscribe to all changes using Gerrit's notification mechanism, and wiki edits use wiki-approvers for access rather than being world-editable.

This is the tracking issue to confirm and clean up accordingly.

CC @ianlancetaylor, @rsc.

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 15, 2023
@dmitshur dmitshur added this to the Unreleased milestone Dec 15, 2023
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Dec 15, 2023
@dmitshur dmitshur moved this to Planned in Go Release Jan 2, 2024
@dmitshur dmitshur self-assigned this Jan 2, 2024
@dmitshur
Copy link
Contributor Author

Discussed this with Ian. We concluded this machinery is indeed fine to remove, and then archive the golang-wikichanges mailing list. Moving to NeedsFix.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 11, 2024
@dmitshur dmitshur moved this from Planned to In Progress in Go Release Jul 24, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/600997 mentions this issue: cloudfns/{sendwikidiff,wikiwebhook}: delete

@dmitshur
Copy link
Contributor Author

dmitshur commented Jul 25, 2024

For posterity and in case we need to restore this or setup something similar in the future:

  • deleted a webhook sending "Wiki" events only to https://us-central1-symbolic-datum-552.cloudfunctions.net/GitHubWikiChangeWebHook (in application/json form, with SSL)
    • also deleted a webhook sending "Issues" events to https://us-central1-symbolic-datum-552.cloudfunctions.net/GitHubIssueChangeWebHook; this was a leftover from issueswebhook deleted in CL 396477
    • both had no recent deliveries, as expected
  • deleted both GitHubWikiChangeWebHook and HandleWikiChangePubSub deployed cloud functions
    • both had no invocations in last 30 days, as expected
    • they were still deployed using the now-deprecated 1st gen cloud function environment and Go 1.20 runtime, which was sufficient until their deletion
  • deleted the github.webhooks.golang.go.wiki Pub/Sub topic used to connect the two cloud functions
    • no messages in last 30 days, as expected
  • CL 600997 deletes the cloud function code from x/build
  • removed posting permission for the account used by WikiDiffBot and updated golang-wikichanges description to note that it is obsolete
    • this seems roughly as close to archiving it as we can get short of fully deleting it

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

No branches or pull requests

2 participants