Skip to content

x/tools/gopls: thoroughly test new file watching heuristics #64724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
findleyr opened this issue Dec 14, 2023 · 3 comments
Closed

x/tools/gopls: thoroughly test new file watching heuristics #64724

findleyr opened this issue Dec 14, 2023 · 3 comments
Assignees
@findleyr
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.15.0

Comments

@findleyr
Copy link
Member

This is a reminder issue to thoroughly test gopls' new file watching heuristics (added as part of #57979), especially in VS Code, and especially on Windows, before releasing.

(these heuristics take advantage of recent bug fixes in VS Code, and we need to verify that they actually work as intended).
@findleyr findleyr added this to the gopls/v0.15.0 milestone Dec 14, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 14, 2023
@findleyr
Copy link
Member Author

Hmm, the CL in question, https://go.dev/cl/550075, may have also had a mild impact on BenchmarkReload.
image
(other benchmarks appear unaffected).

Not significant enough to roll back, but also warranting investigation.

@findleyr findleyr self-assigned this Jan 29, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/559157 mentions this issue: gopls/internal/cache: memoize the view filter func

gopherbot pushed a commit to golang/tools that referenced this issue Jan 29, 2024
@findleyr
gopls/internal/cache: memoize the view filter func
14d7f7b 
Now that options are immutable on the view, we can safely memoize the
view's directory filter function. Do this, which fixes the regression in
BenchmarkReload observed in golang/go#64724.

For golang/go#64724

Change-Id: Iaf8c2d5e69e68e0077f07a72026ef46c0e19bcc0
Reviewed-on: https://go-review.googlesource.com/c/tools/+/559157
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
@findleyr
Copy link
Member Author

findleyr commented Feb 6, 2024

New file watching heuristics seem to work well on Windows.

@findleyr findleyr closed this as completed Feb 6, 2024
@golang golang locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@findleyr findleyr

Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.15.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr