Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/robustio: TestFileInfo missing feature guards for symlinks and hard-links #64701

Closed
bcmills opened this issue Dec 13, 2023 · 1 comment
Closed

x/tools/internal/robustio: TestFileInfo missing feature guards for symlinks and hard-links #64701

bcmills opened this issue Dec 13, 2023 · 1 comment
Assignees
@bcmills
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 13, 2023

Go version

N/A

What operating system and processor architecture are you using (go env)?

N/A

What did you do?

Check x/tools build status on https://ci.chromium.org/p/golang/g/x-tools-gotip/console.

What did you expect to see?

All tests passing.

What did you see instead?

https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-gotip-wasip1-wasm_wasmtime/b8761809133576738257/test-results:

=== RUN   TestFileInfo
    robustio_test.go:57: can't create symbolic link: symlink /tmp/TestFileInfo2274051770/002/real /tmp/TestFileInfo2274051770/004/symlink: Operation not permitted
--- FAIL: TestFileInfo (2.00s)

In general calls to os.Symlink and os.Link can fail on certain configurations of Windows, Android, and wasip1. See testenv.HasSymlink and testenv.HasLink in the main repo.

(attn @findleyr @adonovan)
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Dec 13, 2023
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Dec 13, 2023
@gopherbot gopherbot added this to the Unreleased milestone Dec 13, 2023
@bcmills bcmills self-assigned this Dec 13, 2023
@gopherbot
Copy link

Change https://go.dev/cl/549555 mentions this issue: cmd/guru,internal/robustio: make tests robust to os.Symlink errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcmills bcmills

Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot