-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: timeouts too short on windows-amd64-race
LUCI builder
#64697
Comments
@golang/release
|
Change https://go.dev/cl/550816 mentions this issue: |
Set GO_TEST_TIMEOUT_SCALE=2 for race builders, since the race detector significantly slows down test execution. Doing this required some small changes to make_run_mod() to handle test timeout scale separately from other environment variable changes. Specifically, for the race-longtest builder we want a timeout scale of 5, not 2, hence the code picks the maximum scale set for any given mod. For golang/go#64697. Change-Id: I35bd433c3430c25bd6f75d3959c49f26faef0979 Reviewed-on: https://go-review.googlesource.com/c/build/+/550816 Auto-Submit: Than McIntosh <thanm@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Bypass: Carlos Amedee <carlos@golang.org>
Closing out this issue, the main.star change is now in. |
Found new dashboard test flakes for:
2023-12-13 00:22 gotip-windows-amd64-race go@400e24a8 go/types.TestSelf (log)
|
Found new dashboard test flakes for:
2024-01-17 21:29 x_tools-go1.22-windows-amd64-race tools@c0db45fb release-branch.go1.22@66f8e1e8 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens [ABORT] (log)
2024-01-17 21:29 x_tools-go1.22-windows-amd64-race tools@c0db45fb release-branch.go1.22@66f8e1e8 x/tools/gopls/internal/test/integration/completion.TestFuzzFunc [ABORT] (log)
2024-01-17 21:29 x_tools-go1.22-windows-amd64-race tools@c0db45fb release-branch.go1.22@66f8e1e8 x/tools/gopls/internal/test/integration/misc.TestChangeConfiguration [ABORT] (log)
2024-01-19 13:52 x_tools-go1.21-windows-amd64-race tools@6673e7a4 release-branch.go1.21@2540b143 x/tools/go/packages.TestInvalidFilesBeforeOverlayContains/Modules/second_file [ABORT] (log)
2024-01-19 13:52 x_tools-go1.21-windows-amd64-race tools@6673e7a4 release-branch.go1.21@2540b143 x/tools/go/packages.TestOverlay/Modules [ABORT] (log)
2024-01-19 18:38 x_tools-go1.21-windows-amd64-race tools@c7ccb517 release-branch.go1.21@2540b143 x/tools/go/packages.TestLoadDifferentPatterns [ABORT] (log)
2024-01-19 22:45 x_tools-go1.21-windows-amd64-race tools@cd7b5109 release-branch.go1.21@2540b143 x/tools/go/packages.TestInvalidFilesBeforeOverlayContains/Modules/main [ABORT] (log)
2024-01-19 22:45 x_tools-go1.21-windows-amd64-race tools@cd7b5109 release-branch.go1.21@2540b143 x/tools/go/packages.TestLoadDifferentPatterns/Modules [ABORT] (log)
2024-01-19 23:15 x_tools-go1.22-windows-amd64-race tools@e1555a36 release-branch.go1.22@9a70e17e x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens [ABORT] (log)
2024-01-19 23:15 x_tools-go1.22-windows-amd64-race tools@e1555a36 release-branch.go1.22@9a70e17e x/tools/gopls/internal/test/integration/completion.TestFuzzFunc [ABORT] (log)
2024-01-19 23:15 x_tools-go1.22-windows-amd64-race tools@e1555a36 release-branch.go1.22@9a70e17e x/tools/gopls/internal/test/integration/diagnostics.TestTimeFormatAnalyzer [ABORT] (log)
|
Found new dashboard test flakes for:
2024-01-05 17:34 x_tools-go1.21-windows-amd64-race tools@ba8672b5 release-branch.go1.21@d2cb1401 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens [ABORT] (log)
2024-01-05 17:34 x_tools-go1.21-windows-amd64-race tools@ba8672b5 release-branch.go1.21@d2cb1401 x/tools/gopls/internal/test/integration/completion.TestFuzzFunc [ABORT] (log)
2024-01-05 17:34 x_tools-go1.21-windows-amd64-race tools@ba8672b5 release-branch.go1.21@d2cb1401 x/tools/gopls/internal/test/integration/diagnostics.TestTimeFormatAnalyzer [ABORT] (log)
2024-01-10 16:06 x_tools-go1.21-windows-amd64-race tools@706525de release-branch.go1.21@2540b143 x/tools/gopls/internal/test/integration/completion.TestFuzzFunc [ABORT] (log)
2024-01-10 16:06 x_tools-go1.21-windows-amd64-race tools@706525de release-branch.go1.21@2540b143 x/tools/gopls/internal/test/integration/diagnostics.TestTimeFormatAnalyzer [ABORT] (log)
2024-01-10 16:06 x_tools-go1.21-windows-amd64-race tools@706525de release-branch.go1.21@2540b143 x/tools/gopls/internal/test/integration/modfile.TestModFileModification [ABORT] (log)
|
Found new dashboard test flakes for:
2023-12-13 20:55 x_tools-go1.21-windows-amd64-race tools@9ed4fb5d release-branch.go1.21@bbab863a x/tools/internal/gcimporter.TestStdlib [ABORT] (log)
2023-12-15 17:45 x_tools-go1.22-windows-amd64-race tools@1346c45e release-branch.go1.22@796f59df x/tools/gopls/internal/test/integration/completion.TestFuzzFunc [ABORT] (log)
2023-12-15 17:45 x_tools-go1.22-windows-amd64-race tools@1346c45e release-branch.go1.22@796f59df x/tools/gopls/internal/test/integration/misc.TestChangeConfiguration [ABORT] (log)
2023-12-15 17:45 x_tools-go1.22-windows-amd64-race tools@1346c45e release-branch.go1.22@796f59df x/tools/gopls/internal/test/integration/modfile.TestModFileModification [ABORT] (log)
2023-12-18 20:38 x_tools-go1.21-windows-amd64-race tools@c431729b release-branch.go1.21@bbab863a x/tools/internal/gcimporter.TestStdlib [ABORT] (log)
|
Found new dashboard test flakes for:
2024-01-29 09:09 x_tools-go1.21-windows-amd64-race tools@dd0f88f0 release-branch.go1.21@00f974eb x/tools/go/packages.TestInvalidFilesBeforeOverlayContains/Modules/second_file [ABORT] (log)
|
Found new dashboard test flakes for:
2024-02-06 18:49 x_tools-go1.21-windows-amd64-race tools@6d4ccf2a release-branch.go1.21@f2920803 x/tools/go/packages.TestInvalidFilesBeforeOverlayContains/Modules/main [ABORT] (log)
2024-02-06 18:49 x_tools-go1.21-windows-amd64-race tools@6d4ccf2a release-branch.go1.21@f2920803 x/tools/go/packages.TestLoadDifferentPatterns/Modules [ABORT] (log)
2024-02-06 21:16 x_tools-go1.21-windows-amd64-race tools@0d875898 release-branch.go1.21@f2920803 x/tools/gopls/internal/test/integration/codelens.TestDisablingCodeLens/default/default [ABORT] (log)
2024-02-06 23:06 x_tools-go1.21-windows-amd64-race tools@ab679612 release-branch.go1.21@f2920803 x/tools/internal/gcimporter.TestStdlib [ABORT] (log)
2024-02-07 02:37 x_tools-go1.21-windows-amd64-race tools@c11269cc release-branch.go1.21@f2920803 x/tools/go/packages.TestInvalidFilesBeforeOverlayContains/Modules/main [ABORT] (log)
2024-02-07 02:37 x_tools-go1.21-windows-amd64-race tools@c11269cc release-branch.go1.21@f2920803 x/tools/go/packages.TestLoadDifferentPatterns/Modules/file=C:\b\s\w\ir\x\t\TestLoadDifferentPatterns_Modules1485750803\fake\a\a.go [ABORT] (log)
2024-02-07 19:14 x_tools-go1.21-windows-amd64-race tools@acf07b3c release-branch.go1.21@f2920803 x/tools/go/packages.TestInvalidFilesBeforeOverlayContains/Modules/main [ABORT] (log)
2024-02-07 19:14 x_tools-go1.21-windows-amd64-race tools@acf07b3c release-branch.go1.21@f2920803 x/tools/go/packages.TestLoadDifferentPatterns/Modules [ABORT] (log)
|
Found new dashboard test flakes for:
2024-02-08 13:20 x_tools-go1.21-windows-amd64-race tools@f4fa7a75 release-branch.go1.21@f997dfd3 x/tools/go/packages.TestInvalidFilesBeforeOverlayContains/Modules/main [ABORT] (log)
2024-02-08 13:20 x_tools-go1.21-windows-amd64-race tools@f4fa7a75 release-branch.go1.21@f997dfd3 x/tools/go/packages.TestLoadDifferentPatterns/Modules [ABORT] (log)
2024-02-09 17:45 x_tools-go1.21-windows-amd64-race tools@96196832 release-branch.go1.21@b214108e x/tools/internal/gcimporter.TestStdlib [ABORT] (log)
|
Found new dashboard test flakes for:
2024-02-09 20:28 x_tools-go1.21-windows-amd64-race tools@8cf0a8e2 release-branch.go1.21@b214108e x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens/Upgrade_direct_dependencies/default [ABORT] (log)
2024-02-09 20:28 x_tools-go1.21-windows-amd64-race tools@8cf0a8e2 release-branch.go1.21@b214108e x/tools/gopls/internal/test/integration/diagnostics.TestTimeFormatAnalyzer/default [ABORT] (log)
2024-02-09 20:28 x_tools-go1.21-windows-amd64-race tools@8cf0a8e2 release-branch.go1.21@b214108e x/tools/gopls/internal/test/integration/modfile.TestModFileModification/basic/default/default [ABORT] (log)
|
Found new dashboard test flakes for:
2024-02-12 22:10 x_tools-gotip-windows-amd64-race tools@c5643e9b go@0336d5eb x/tools/gopls/internal/test/integration/completion.TestFuzzFunc/default [ABORT] (log)
2024-02-12 22:10 x_tools-gotip-windows-amd64-race tools@c5643e9b go@0336d5eb x/tools/gopls/internal/test/integration/diagnostics.TestTimeFormatAnalyzer/default [ABORT] (log)
2024-02-12 22:10 x_tools-gotip-windows-amd64-race tools@c5643e9b go@0336d5eb x/tools/gopls/internal/test/integration/modfile.TestModFileModification/basic/default/default [ABORT] (log)
2024-02-14 21:33 x_tools-go1.21-windows-amd64-race tools@df9c1c7e release-branch.go1.21@b214108e x/tools/internal/gcimporter.TestStdlib [ABORT] (log)
|
Found new dashboard test flakes for:
2024-02-15 17:22 x_tools-go1.21-windows-amd64-race tools@7240af8b release-branch.go1.21@b214108e x/tools/internal/gcimporter.TestStdlib [ABORT] (log)
2024-02-15 17:22 x_tools-gotip-windows-amd64-race tools@7240af8b go@b6ca5861 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens [ABORT] (log)
2024-02-15 17:22 x_tools-gotip-windows-amd64-race tools@7240af8b go@b6ca5861 x/tools/gopls/internal/test/integration/completion.TestFuzzFunc [ABORT] (log)
2024-02-15 17:22 x_tools-gotip-windows-amd64-race tools@7240af8b go@b6ca5861 x/tools/gopls/internal/test/integration/diagnostics.TestTimeFormatAnalyzer [ABORT] (log)
|
Duplicate of #65845 |
Go version
400e24a
What operating system and processor architecture are you using (
go env
)?What did you do?
Check post-commit build status at https://ci.chromium.org/p/golang/g/go-gotip/console.
What did you expect to see?
Tests reliably passing.
What did you see instead?
https://ci.chromium.org/ui/p/golang/builders/ci/gotip-windows-amd64-race/b8761869653601911985/test-results:
Note that the timeout for the test is the default 3m0s.
In contrast, the legacy
windows-amd64-race
builder usesGO_TEST_TIMEOUT_SCALE=2
, which would imply a 6m timeout for this test.(https://cs.opensource.google/go/x/build/+/master:dashboard/builders.go;l=2340;drc=106fb71fb120a066e390426df597efa8e674a6e0)
The text was updated successfully, but these errors were encountered: