Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestLookupDotsWithLocalSource failures #64689

Open
gopherbot opened this issue Dec 12, 2023 · 2 comments
Open

net: TestLookupDotsWithLocalSource failures #64689

gopherbot opened this issue Dec 12, 2023 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link 

#!watchflakes
default <- pkg == "net" && test == "TestLookupDotsWithLocalSource"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestLookupDotsWithLocalSource (0.00s)
    lookup_test.go:626: netgo: got localhost.; want localhost

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 12, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net" && test == "TestLookupDotsWithLocalSource"
2023-12-12 19:42 windows-amd64-2016 go@c2079deb net.TestLookupDotsWithLocalSource (log) 
--- FAIL: TestLookupDotsWithLocalSource (0.00s)
    lookup_test.go:626: netgo: got localhost.; want localhost

— watchflakes

@mateusz834
Copy link
Member

mateusz834 commented Dec 13, 2023 •
edited

The go resolver might return localhost., when the order is not hostLookupFilesDNS/hostLookupFiles or the hosts file does not have localhost defined there.

go/src/net/dnsclient_unix.go

Line 891 in f2d243d

ptrs = append(ptrs, ptr.PTR.String())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gopherbot @mateusz834