Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: update doc to include Helix editor #64685

Closed
achenet opened this issue Dec 12, 2023 · 9 comments
Closed

x/tools/gopls: update doc to include Helix editor #64685

achenet opened this issue Dec 12, 2023 · 9 comments
Labels
Documentation gopls Issues related to the Go language server, gopls. help wanted NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@achenet
Copy link

achenet commented Dec 12, 2023

gopls version

0.14.2

go env

GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/utilisateur/.cache/go-build'
GOENV='/home/utilisateur/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/utilisateur/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/utilisateur/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/home/utilisateur/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/home/utilisateur/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21.5'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build2230977179=/tmp/go-build -gno-record-gcc-switches'

What did you do?

I'd like to add a some documentation explaining how to setup gopls with the helix text editor

What did you expect to see?

This isn't exactly a bug, I'd like to see more docuementation explaining how to setup gopls with the helix text editor, and given that the contribution guidelines say to create an issue first, I'm doing that.

What did you see instead?

I'm seeing a that perhaps this form isn't perfectly suited to every type of issue.

Editor and settings

No response

Logs

No response

@achenet achenet added gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. labels Dec 12, 2023
@gopherbot gopherbot added this to the Unreleased milestone Dec 12, 2023
@prattmic prattmic added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 12, 2023
@findleyr
Copy link
Contributor

Thanks. Please feel free to send a CL contributing documentation!

@achenet
Copy link
Author

achenet commented Dec 13, 2023

Thanks. Please feel free to send a CL contributing documentation!

yep, that's the plan. I must admit to being a bit unsure as to how exactly to go about opening a CL to the doc, so feel free to link me to the appropriate documentation if you can, if not I'll wander around and try stuff until I figure it out :)

@findleyr
Copy link
Contributor

@achenet please see https://go.dev/doc/contribute for a guide on how to contribute to Go projects.

@achenet
Copy link
Author

achenet commented Dec 13, 2023

ok, thanks :)

@achenet
Copy link
Author

achenet commented Jan 3, 2024

@findleyr
Copy link
Contributor

findleyr commented Jan 8, 2024

Thanks! I added some comments, along with @mvdan.

@achenet
Copy link
Author

achenet commented Jan 9, 2024

thanks for taking the time to review it ^_^
I'll apply your suggestions and update the CR.

@gopherbot
Copy link

Change https://go.dev/cl/553775 mentions this issue: gopls/doc: add helix ediotr doc for gopls

@gopherbot
Copy link

Change https://go.dev/cl/553775 mentions this issue: gopls/doc: add helix editor documentation for gopls

@seankhliao seankhliao changed the title x/tools/gopls: Update doc to include Helix editor x/tools/gopls: update doc to include Helix editor Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation gopls Issues related to the Go language server, gopls. help wanted NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

5 participants