Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: PGO devirtualization of closures #64675

Open
Tracked by #62463
prattmic opened this issue Dec 12, 2023 · 0 comments
Open
Tracked by #62463

cmd/compile: PGO devirtualization of closures #64675

prattmic opened this issue Dec 12, 2023 · 0 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Performance
Milestone

Comments

@prattmic
Copy link
Member

https://go.dev/cl/539699 adds PGO devirtualization of calls to function values, but it is limited to callees that are standard functions. Closures (any function requiring closure context) are excluded due to the extra complexity of passing the closure context.

It should be feasible to devirtualize these calls, but will require extra work in SSA to pass a closure context to a closure call as well as work in IR to represent such static closure calls.

cc @cherrymui @aclements @mdempsky

@prattmic prattmic added Performance NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 12, 2023
@prattmic prattmic added this to the Backlog milestone Dec 12, 2023
@prattmic prattmic changed the title cmd/go: PGO devirtualization of closures cmd/compile: PGO devirtualization of closures Dec 12, 2023
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Performance
Projects
Development

No branches or pull requests

2 participants