Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/cgo: _cgo_allocate can not work with precise GC #6461

Closed
ianlancetaylor opened this issue Sep 23, 2013 · 9 comments
Closed

runtime/cgo: _cgo_allocate can not work with precise GC #6461

ianlancetaylor opened this issue Sep 23, 2013 · 9 comments
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@ianlancetaylor
Copy link
Contributor 

We currently provide a _cgo_allocate function in the runtime/cgo package.  This function
is mentioned in the cgo documentation, though without documentation.  It is provided to
SWIG code under the name swig_goallocate.

This function can not work with fully precise GC, because there is no type information
for the allocated memory.

We need to figure out a way to address this consonant with the Go 1 guarantee.
@rsc
Copy link
Contributor

rsc commented Sep 23, 2013

Comment 1:

_cgo_allocate is not documented. It is in doc.go but only in the "implementation
details" section, which is not part of the command documentation.  The _swig_goallocate
wrapper needs to be removed in favor of something else, but I don't believe the Go 1
compatibility rules cover swig. Even if they did, I would put this in the "specification
error" exception.

@dvyukov
Copy link
Member

dvyukov commented Sep 23, 2013

Comment 2:

>_cgo_allocate is not documented. It is in doc.go but only in the "implementation
details" section, which is not part of the command documentation.
great!

@rsc
Copy link
Contributor

rsc commented Sep 24, 2013

Comment 3:

Labels changed: added go1.3, removed go1.2.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 4:

Labels changed: added release-go1.3.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 5:

Labels changed: removed go1.3.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 6:

Labels changed: added repo-main.

@rsc
Copy link
Contributor

rsc commented Apr 3, 2014

Comment 7:

It looks like nothing is going to happen for Go 1.3. I hope SWIG still works!

Labels changed: added release-go1.4, removed release-go1.3.

@rsc
Copy link
Contributor

rsc commented Sep 18, 2014

Comment 8:

It looks like nothing is going to happen for Go 1.4. I hope SWIG still works!

Labels changed: added release-go1.5, removed release-go1.4.

@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014
@rsc
Copy link
Contributor

rsc commented Jun 29, 2015

cgo_allocate is gone, and the latest SWIG has been updated. Yay!

@rsc rsc closed this as completed Jun 29, 2015
@golang golang locked and limited conversation to collaborators Jun 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
5 participants
@bradfitz @rsc @dvyukov @ianlancetaylor @gopherbot