-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: add LUCI linux-ppc64_power10 builder #64588
Comments
Thanks. This is similar to #61274, except it's CC @golang/release. |
Change https://go.dev/cl/548217 mentions this issue: |
For golang/go#64588 Change-Id: I59ce0dec9caa4d2080d27d4649f1a6b01de7afab Reviewed-on: https://go-review.googlesource.com/c/build/+/548217 Reviewed-by: Carlos Amedee <carlos@golang.org> TryBot-Bypass: Carlos Amedee <carlos@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Here's the resulting certificate: linux-ppc64-power10-1702068073.cert.txt. The builder definitions have been added in CL 548217 so your bot should be able to connect once you follow the rest of the steps on your end. |
Thanks! I have one instance started and running. |
That was fast, and we now have its first green build! https://ci.chromium.org/b/8762240340084651697 Thanks very much. Would you like to keep this issue open a bit longer (e.g., while you're adding more instances), or okay to close now? |
Is the GOPPC64=power10 envvar configured for this builder? I didn't see it listed when I clicked through the log above. Should I be configuring that on the builder itself, or is the luci coordinator responsible for setting that? |
Good point, it ended up as its default value of The optimal place to set it might be in our builder configuration (edit: sent CL 547982 for this), though it's also okay for you to do it in the builder's environment if that doesn't get in the way of something else. Update: It's using |
Change https://go.dev/cl/547982 mentions this issue: |
This builder is intended to test the linux/ppc64 port with GOPPC64 set to power10, up from its default value of power8. Use a run mod to achieve this. For golang/go#64588. Change-Id: I535e42d1e8e41b54e00b08474ff7d4f6b2712c52 Reviewed-on: https://go-review.googlesource.com/c/build/+/547982 Reviewed-by: Carlos Amedee <carlos@golang.org> TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Checking in on the status of this in progress new-builder issue. Is there more to do here before closing it? |
Change https://go.dev/cl/575856 mentions this issue: |
Per discussion in go.dev/issue/64660, the intent is to have distinct hardware test the GOOS=linux GOARCH=ppc64{,le} GOPPC64=power{8,9,10} Go ports, instead of using the same hardware with a different value of the GOPPC64 environment variable set. By now crrev.com/c/5178250 has propagated and the swarming bot reports in its 'cpu' dimension whether it's a POWER{8,9,10} type of CPU. Update our configuration accordingly: make it a property of the host which type of CPU should be matched, and replace the previous power10 runmod in favor of setting the GOPPC64 env var explicitly as part of the builder definition (since a runmod is redundant with the host suffix and would make the builder name more repetitive). After this change is in, it will become possible to have hardware for testing the GOOS=linux GOARCH=ppc64le GOPPC64=power10 port connect to LUCI and not get selected as a host for the LUCI builder now defined as 'linux-ppc64le_power8' (previously defined as 'linux-ppc64le'). For golang/go#64660. For golang/go#64588. Change-Id: I1bf00231c46a29052c3e3dfce92f6bea20fea708 Reviewed-on: https://go-review.googlesource.com/c/build/+/575856 Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@pmur Should this issue also be closed, or is there more to do for it? |
No, this should be done. |
This will be the LUCI
GOPPC64=power10 GOARCH=ppc64 GOOS=linux
builder replacement forhost-linux-ppc64-sid-power10
.It will share the same VM resources as
host-linux-ppc64-sid-power10
. The hostname should belinux-ppc64-power10
.Certificate attached: linux-ppc64-power10.csr.txt
The text was updated successfully, but these errors were encountered: