x/tools/gopls: "internal error converting diagnostic" (bug reported by telemetry) #64547

adonovan · 2023-12-05T00:11:28Z

This stack o6rQWQ was reported by telemetry:

cache.(*action).exec.func3:3 is :

		Report: func(d analysis.Diagnostic) {
			diagnostic, err := toGobDiagnostic(posToLocation, analyzer, d)
			if err != nil {
				bug.Reportf("internal error converting diagnostic from analyzer %q: %v", analyzer.Name, err)
				return
			}
			diagnostics = append(diagnostics, diagnostic)
		},

Variant stacks from cgocall analyzer: t5Iynw, anAjSQ, WNmwJA, lkeNLw, 1ZKXaA, iv8Nzg, 99HJig, o9Ch_g.

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Reportf:1
golang.org/x/tools/gopls/internal/lsp/cache.(*action).exec.func3:3
golang.org/x/tools/go/analysis.(*Pass).ReportRangef:2
golang.org/x/tools/go/analysis/passes/lostcancel.runFunc:108
golang.org/x/tools/go/analysis/passes/lostcancel.run.func1:1
golang.org/x/tools/go/ast/inspector.(*Inspector).Preorder:11
golang.org/x/tools/go/analysis/passes/lostcancel.run:12
golang.org/x/tools/gopls/internal/lsp/cache.(*action).exec.func6:31
golang.org/x/tools/gopls/internal/lsp/cache.(*action).exec:177
golang.org/x/tools/gopls/internal/lsp/cache.execActions.func1.1:2
sync.(*Once).doSlow:5
sync.(*Once).Do:?65
golang.org/x/tools/gopls/internal/lsp/cache.execActions.func1:2
runtime.goexit:0

golang.org/x/tools/gopls@v0.14.2 go1.21.3 darwin/amd64 (1)

Errors from toGobDiagnostic must come from posToLocation, which can fail if a token.Pos from the analyzer (in this case, a valid ReturnStmt in lostcancel) either doesn't belong to the FileSet or is invalid per safetoken.Offset. I suspect this is another case of AST fixing making offsets invalid.

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

Dups:

This stack 6NklUg was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Reportf:1
golang.org/x/tools/gopls/internal/lsp/cache.(*action).exec.func3:3
golang.org/x/tools/go/analysis.(*Pass).Reportf:2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:28
go/ast.inspector.Visit:1
go/ast.Walk:1
go/ast.walkExprList:?26
go/ast.Walk:167
go/ast.Walk:188
go/ast.walkStmtList:?32
go/ast.Walk:184
go/ast.Walk:307
go/ast.walkDeclList:?38
go/ast.Walk:316
go/ast.Inspect:?397

golang.org/x/tools/gopls@v0.14.2 go1.21.1 darwin/arm64 vscode (4)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

This stack pDy33Q was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Errorf:2
golang.org/x/tools/gopls/internal/lsp/cache.(*action).exec.func2:11
golang.org/x/tools/gopls/internal/lsp/cache.toGobDiagnostic:32
golang.org/x/tools/gopls/internal/lsp/cache.(*action).exec.func3:1
golang.org/x/tools/go/analysis.(*Pass).Reportf:2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:28
go/ast.inspector.Visit:1
go/ast.Walk:1
go/ast.walkExprList:?26
go/ast.Walk:167
go/ast.Walk:188
go/ast.walkStmtList:?32
go/ast.Walk:184
go/ast.Walk:307
go/ast.walkDeclList:?38

golang.org/x/tools/gopls@v0.14.2 go1.21.1 darwin/arm64 vscode (4)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

This stack WQ0V3g was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+4
golang.org/x/tools/gopls/internal/analysis/noresultvalues.run.func1:+25
golang.org/x/tools/go/ast/inspector.(*Inspector).Preorder:+11
golang.org/x/tools/gopls/internal/analysis/noresultvalues.run:+7
golang.org/x/tools/gopls/internal/cache.(*action).exec.func6:+31
golang.org/x/tools/gopls/internal/cache.(*action).exec:+193
golang.org/x/tools/gopls/internal/cache.execActions.func1.1:+2
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.execActions.func1:+2
runtime.goexit:+0

golang.org/x/tools/gopls@v0.15.1 go1.21.3 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

This stack HGXlMQ was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+4
honnef.co/go/tools/analysis/report.Report:+25
honnef.co/go/tools/staticcheck.CheckTypedNilInterface:+100
golang.org/x/tools/gopls/internal/cache.(*action).exec.func6:+31
golang.org/x/tools/gopls/internal/cache.(*action).exec:+193
golang.org/x/tools/gopls/internal/cache.execActions.func1.1:+2
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.execActions.func1:+2
runtime.goexit:+0

golang.org/x/tools/gopls@v0.15.1 go1.22.0 darwin/arm64 other,vscode-insiders (3)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

This stack Kf5dlg was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+4
honnef.co/go/tools/analysis/report.Report:+25
honnef.co/go/tools/staticcheck.CheckTypedNilInterface:+100
golang.org/x/tools/gopls/internal/cache.(*action).exec.func6:+31
golang.org/x/tools/gopls/internal/cache.(*action).exec:+215
golang.org/x/tools/gopls/internal/cache.execActions.func1.1:+2
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.execActions.func1:+2
runtime.goexit:+0

golang.org/x/tools/gopls@v0.15.3 go1.22.2 darwin/arm64 other,vscode-insiders (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

Dup: qaVg3w Eqzixw HRixng g_9bVA 3BjAWg 5rID1Q J_xyOQ nkqhZw DD7DZw KXNLJA aabnaw xEGAsg V5I6ag AjGTng y5Uv9w nJQxXw uxzQyw Kf5dlg W-MgtA HkRVLw

The text was updated successfully, but these errors were encountered:

adonovan · 2023-12-26T14:30:06Z

All these stacks appear to come from the cgocall analyzer. I suspect it is special because of cgo's use of //line directives, which cause the apparent file offsets not to match the actual file size.

gopherbot · 2024-01-18T20:26:29Z

Change https://go.dev/cl/556815 mentions this issue: gopls/internal/lsp/cache: fix bug reports from toGobDiagnostics

adonovan · 2024-03-07T22:35:55Z

Reopening due to field report in v0.15.1, after the supposed fix in CL https://go.dev/cl/556815:

This stack WQ0V3g was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+4
golang.org/x/tools/gopls/internal/analysis/noresultvalues.run.func1:+25
golang.org/x/tools/go/ast/inspector.(*Inspector).Preorder:+11
golang.org/x/tools/gopls/internal/analysis/noresultvalues.run:+7
golang.org/x/tools/gopls/internal/cache.(*action).exec.func6:+31
golang.org/x/tools/gopls/internal/cache.(*action).exec:+193
golang.org/x/tools/gopls/internal/cache.execActions.func1.1:+2
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.execActions.func1:+2
runtime.goexit:+0

golang.org/x/tools/gopls@v0.15.1 go1.21.3 linux/amd64 vscode (1)

gopherbot · 2024-03-07T22:42:37Z

Change https://go.dev/cl/569935 mentions this issue: gopls/internal/cache: add assertions for telemetry crash

Updates golang/go#64547 Change-Id: I35b2477b8f6182bf6774095f18726104227a2fcd Reviewed-on: https://go-review.googlesource.com/c/tools/+/569935 Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Alan Donovan <adonovan@google.com>

gopherbot · 2024-03-08T17:14:17Z

Change https://go.dev/cl/569880 mentions this issue: [gopls-release-branch.0.15] gopls/internal/cache: add assertions for telemetry crash

…telemetry crash Updates golang/go#64547 Change-Id: I35b2477b8f6182bf6774095f18726104227a2fcd Reviewed-on: https://go-review.googlesource.com/c/tools/+/569935 Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Alan Donovan <adonovan@google.com> (cherry picked from commit 31f056a) Reviewed-on: https://go-review.googlesource.com/c/tools/+/569880 Auto-Submit: Robert Findley <rfindley@google.com> Reviewed-by: Alan Donovan <adonovan@google.com>

adonovan · 2024-03-08T21:02:51Z

This stack qaVg3w was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*action).exec.func2:+15
golang.org/x/tools/gopls/internal/cache.toGobDiagnostic:+22
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+1
honnef.co/go/tools/analysis/report.Report:+25
honnef.co/go/tools/staticcheck.CheckTypedNilInterface:+100
golang.org/x/tools/gopls/internal/cache.(*action).exec.func6:+31
golang.org/x/tools/gopls/internal/cache.(*action).exec:+193
golang.org/x/tools/gopls/internal/cache.execActions.func1.1:+2
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.execActions.func1:+2
runtime.goexit:+0

golang.org/x/tools/gopls@v0.15.1 go1.22.0 darwin/arm64 other,vscode-insiders (3)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-03-14T15:13:19Z

This stack Eqzixw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+4
golang.org/x/tools/go/analysis.(*Pass).Reportf:+2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:+28
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.walkExprList:+2
go/ast.Walk:+167
go/ast.Walk:+188
go/ast.walkStmtList:+2
go/ast.Walk:+184
go/ast.Walk:+307
go/ast.walkDeclList:+2
go/ast.Walk:+316
go/ast.Inspect:=397

golang.org/x/tools/gopls@v0.15.0 go1.20.14 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-03-14T15:14:58Z

This stack HRixng was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*action).exec.func2:+15
golang.org/x/tools/gopls/internal/cache.toGobDiagnostic:+32
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+1
golang.org/x/tools/go/analysis.(*Pass).Reportf:+2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:+28
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.walkExprList:+2
go/ast.Walk:+167
go/ast.Walk:+188
go/ast.walkStmtList:+2
go/ast.Walk:+184
go/ast.Walk:+307
go/ast.walkDeclList:+2

golang.org/x/tools/gopls@v0.15.0 go1.20.14 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-03-31T15:34:34Z

This stack g_9bVA was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*action).exec.func2:+24
golang.org/x/tools/gopls/internal/cache.toGobDiagnostic:+22
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+1
honnef.co/go/tools/analysis/report.Report:+25
honnef.co/go/tools/staticcheck.CheckTypedNilInterface:+100
golang.org/x/tools/gopls/internal/cache.(*action).exec.func6:+31
golang.org/x/tools/gopls/internal/cache.(*action).exec:+202
golang.org/x/tools/gopls/internal/cache.execActions.func1.1:+2
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.execActions.func1:+2
runtime.goexit:+0

golang.org/x/tools/gopls@v0.15.2 go1.22.0 darwin/arm64 vscode-insiders (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-03-31T15:35:10Z

This stack 3BjAWg was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+4
honnef.co/go/tools/analysis/report.Report:+25
honnef.co/go/tools/staticcheck.CheckTypedNilInterface:+100
golang.org/x/tools/gopls/internal/cache.(*action).exec.func6:+31
golang.org/x/tools/gopls/internal/cache.(*action).exec:+202
golang.org/x/tools/gopls/internal/cache.execActions.func1.1:+2
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.execActions.func1:+2
runtime.goexit:+0

golang.org/x/tools/gopls@v0.15.2 go1.22.0 darwin/arm64 vscode-insiders (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-04-04T18:10:58Z

This stack 5rID1Q was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+4
golang.org/x/tools/go/analysis.(*Pass).Reportf:+2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:+28
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.walkExprList:=26
go/ast.Walk:+167
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+307
go/ast.walkDeclList:=38
go/ast.Walk:+316
go/ast.Inspect:=397
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo:+1

golang.org/x/tools/gopls@v0.15.2 go1.22.0 windows/amd64 neovim,vscode (4)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-04-04T18:13:30Z

This stack J_xyOQ was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*action).exec.func2:+24
golang.org/x/tools/gopls/internal/cache.toGobDiagnostic:+32
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+1
golang.org/x/tools/go/analysis.(*Pass).Reportf:+2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:+28
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.walkExprList:=26
go/ast.Walk:+167
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+307
go/ast.walkDeclList:=38
go/ast.Walk:+316

golang.org/x/tools/gopls@v0.15.2 go1.22.0 windows/amd64 neovim,vscode (4)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-04-04T18:13:57Z

This stack nkqhZw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*action).exec.func2:+24
golang.org/x/tools/gopls/internal/cache.toGobDiagnostic:+32
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+1
golang.org/x/tools/go/analysis.(*Pass).Reportf:+2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:+28
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+156
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+245
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.walkStmtList:=32

golang.org/x/tools/gopls@v0.15.2 go1.22.0 darwin/arm64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-04-04T18:14:29Z

This stack DD7DZw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+4
golang.org/x/tools/go/analysis.(*Pass).Reportf:+2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:+28
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+156
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+245
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+307

golang.org/x/tools/gopls@v0.15.2 go1.22.0 darwin/arm64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

gopherbot · 2024-04-04T20:56:42Z

Change https://go.dev/cl/576655 mentions this issue: gopls/internal/cache: analysis: repair start/end and refine bug report

gopherbot · 2024-04-04T20:56:42Z

Change https://go.dev/cl/576656 mentions this issue: gopls/internal/cmd: check: print RelatedInformation

Poor parser error recovery may cause Node.End to be zero, or a small positive displacement from zero due to recursive Node.End computation (#66683). This change further refines the bug.Reports for such problems, and additionally repairs the values heuristically to avoid downstream bug.Reports after toGobDiagnostics (#64547). Updates golang/go#66683 Updates golang/go#64547 Change-Id: I7c795622ec6b63574978d2953c82036fcc4425af Reviewed-on: https://go-review.googlesource.com/c/tools/+/576655 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Findley <rfindley@google.com>

adonovan · 2024-04-07T15:29:11Z

This stack KXNLJA was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*action).exec.func2:+24
golang.org/x/tools/gopls/internal/cache.toGobDiagnostic:+32
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+1
golang.org/x/tools/go/analysis.(*Pass).Reportf:+2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:+28
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.walkExprList:=26
go/ast.Walk:+268
go/ast.Walk:+294
go/ast.Walk:+146
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+307

golang.org/x/tools/gopls@v0.15.2 go1.22.0 linux/amd64 other,vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-04-07T15:29:49Z

This stack aabnaw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+4
golang.org/x/tools/go/analysis.(*Pass).Reportf:+2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:+28
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+156
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+307
go/ast.walkDeclList:=38
go/ast.Walk:+316
go/ast.Inspect:=397
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo:+1
golang.org/x/tools/go/analysis/passes/cgocall.run:+10

golang.org/x/tools/gopls@v0.15.2 go1.22.1 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-04-07T15:30:19Z

This stack xEGAsg was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*action).exec.func2:+24
golang.org/x/tools/gopls/internal/cache.toGobDiagnostic:+32
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+1
golang.org/x/tools/go/analysis.(*Pass).Reportf:+2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:+28
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+156
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+307
go/ast.walkDeclList:=38
go/ast.Walk:+316
go/ast.Inspect:=397

golang.org/x/tools/gopls@v0.15.2 go1.22.1 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-04-07T15:30:46Z

This stack V5I6ag was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+4
golang.org/x/tools/go/analysis.(*Pass).Reportf:+2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:+28
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.walkExprList:=26
go/ast.Walk:+268
go/ast.Walk:+294
go/ast.Walk:+146
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+307
go/ast.walkDeclList:=38
go/ast.Walk:+316

golang.org/x/tools/gopls@v0.15.2 go1.22.0 linux/amd64 other,vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-04-07T15:31:12Z

This stack AjGTng was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*action).exec.func2:+24
golang.org/x/tools/gopls/internal/cache.toGobDiagnostic:+32
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+1
golang.org/x/tools/go/analysis.(*Pass).Reportf:+2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:+28
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.walkExprList:=26
go/ast.Walk:+94
go/ast.Walk:+156
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+307
go/ast.walkDeclList:=38

golang.org/x/tools/gopls@v0.15.2 go1.22.1 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-04-07T15:31:41Z

This stack y5Uv9w was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+4
golang.org/x/tools/go/analysis.(*Pass).Reportf:+2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:+28
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.walkExprList:=26
go/ast.Walk:+94
go/ast.Walk:+156
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+307
go/ast.walkDeclList:=38
go/ast.Walk:+316
go/ast.Inspect:=397

golang.org/x/tools/gopls@v0.15.2 go1.22.1 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

gopherbot · 2024-04-09T14:15:57Z

Change https://go.dev/cl/577595 mentions this issue: [gopls-release-branch.0.15] gopls/internal/cache: analysis: repair start/end and refine bug report

…art/end and refine bug report Poor parser error recovery may cause Node.End to be zero, or a small positive displacement from zero due to recursive Node.End computation (#66683). This change further refines the bug.Reports for such problems, and additionally repairs the values heuristically to avoid downstream bug.Reports after toGobDiagnostics (#64547). Updates golang/go#66683 Updates golang/go#64547 Updates golang/go#66730 Change-Id: I7c795622ec6b63574978d2953c82036fcc4425af Reviewed-on: https://go-review.googlesource.com/c/tools/+/576655 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Findley <rfindley@google.com> (cherry picked from commit c7b6b8d) Reviewed-on: https://go-review.googlesource.com/c/tools/+/577595 Auto-Submit: Alan Donovan <adonovan@google.com>

The check command previously ignored Diagnostic.RelatedInformation, which confused me as I was trying to run an experiment related to golang/go#64547. This change causes it print the related errors. + test (Aside: there's a lot of weirdness in the way that check.typeErrorsToDiagnostics constructs the response, as you will see if you run the test on c.go not c2.go, but that's not the test's concern.) Change-Id: I14efbf8f2e47ac00c2e7d6eceeacbaaecab88213 Reviewed-on: https://go-review.googlesource.com/c/tools/+/576656 Reviewed-by: Robert Findley <rfindley@google.com> Auto-Submit: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

adonovan · 2024-04-18T22:01:13Z

This stack uxzQyw was reported by telemetry:

		bug.Reportf("internal error converting diagnostic from analyzer %q: %v", analyzer.Name, err)

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+4
golang.org/x/tools/go/analysis.(*Pass).Reportf:+2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:+28
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+173
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+245
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+307
go/ast.walkDeclList:=38
go/ast.Walk:+316

golang.org/x/tools/gopls@v0.15.3 go1.22.0 windows/amd64 neovim,vscode (2)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-04-19T15:36:18Z

This stack uxzQyw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+4
golang.org/x/tools/go/analysis.(*Pass).Reportf:+2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:+28
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+173
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+245
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+307
go/ast.walkDeclList:=38
go/ast.Walk:+316

golang.org/x/tools/gopls@v0.15.3 go1.22.0 windows/amd64 neovim,vscode (2)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-04-19T19:58:26Z

This stack uxzQyw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+4
golang.org/x/tools/go/analysis.(*Pass).Reportf:+2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:+28
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+173
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+245
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+307
go/ast.walkDeclList:=38
go/ast.Walk:+316

golang.org/x/tools/gopls@v0.15.3 go1.22.0 windows/amd64 neovim,vscode (2)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-04-22T18:25:57Z

This stack uxzQyw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+4
golang.org/x/tools/go/analysis.(*Pass).Reportf:+2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:+28
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+173
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+245
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+307
go/ast.walkDeclList:=38
go/ast.Walk:+316

golang.org/x/tools/gopls@v0.15.3 go1.22.0 windows/amd64 neovim,vscode (2)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

gopherbot · 2024-04-22T20:09:36Z

Change https://go.dev/cl/580836 mentions this issue: gopls/internal/cache: fix bug.Report converting Diagnostic positions

adonovan · 2024-04-22T20:21:56Z

The issue with cgocall is not its use of //line directives, but the fact that it parses (and typechecks!) the files again, so the diagnostics are reported against positions not among the 'parsed' set of files; see #66911 (comment).

adonovan · 2024-04-23T15:12:02Z

This stack uxzQyw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+4
golang.org/x/tools/go/analysis.(*Pass).Reportf:+2
golang.org/x/tools/go/analysis/passes/cgocall.checkCgo.func1:+28
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+173
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+245
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+307
go/ast.walkDeclList:=38
go/ast.Walk:+316

golang.org/x/tools/gopls@v0.15.3 go1.22.0 windows/amd64 neovim,vscode (2)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-05-02T18:38:35Z

This stack W-MgtA was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*action).exec.func2:+37
golang.org/x/tools/gopls/internal/cache.toGobDiagnostic:+22
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+1
honnef.co/go/tools/analysis/report.Report:+25
honnef.co/go/tools/staticcheck.CheckTypedNilInterface:+100
golang.org/x/tools/gopls/internal/cache.(*action).exec.func6:+31
golang.org/x/tools/gopls/internal/cache.(*action).exec:+215
golang.org/x/tools/gopls/internal/cache.execActions.func1.1:+2
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.execActions.func1:+2
runtime.goexit:+0

golang.org/x/tools/gopls@v0.15.3 go1.22.2 darwin/arm64 other,vscode-insiders (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

adonovan · 2024-05-03T13:12:53Z

This stack HkRVLw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*action).exec.func2:+26
golang.org/x/tools/gopls/internal/cache.toGobDiagnostic:+32
golang.org/x/tools/gopls/internal/cache.(*action).exec.func3:+1
golang.org/x/tools/gopls/internal/analysis/noresultvalues.run.func1:+25
golang.org/x/tools/go/ast/inspector.(*Inspector).Preorder:+11
golang.org/x/tools/gopls/internal/analysis/noresultvalues.run:+7
golang.org/x/tools/gopls/internal/cache.(*action).exec.func6:+31
golang.org/x/tools/gopls/internal/cache.(*action).exec:+215
golang.org/x/tools/gopls/internal/cache.execActions.func1.1:+2
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.execActions.func1:+2
runtime.goexit:+0

golang.org/x/tools/gopls@v0.15.3 go1.22.0 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

gopherbot added this to the Unreleased milestone Dec 5, 2023

hyangah modified the milestones: Unreleased, gopls/v0.15.0 Dec 7, 2023

findleyr self-assigned this Jan 18, 2024

gopherbot closed this as completed in golang/tools@d0930db Jan 19, 2024

adonovan mentioned this issue Feb 13, 2024

x/tools/gopls: toGobDiagnostic bug reported by telemetry #65695

Closed

adonovan reopened this Mar 7, 2024

adonovan self-assigned this Mar 7, 2024

adonovan modified the milestones: gopls/v0.15.0, gopls/v0.16.0 Mar 7, 2024

adonovan mentioned this issue Apr 4, 2024

go/parser: StructType.End() can underflow the File #66683

Open

adonovan mentioned this issue Apr 18, 2024

x/tools/gopls: cgocall analyzer: "token.Pos not within package" bug (reported by telemetry) #66911

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/gopls: "internal error converting diagnostic" (bug reported by telemetry) #64547

x/tools/gopls: "internal error converting diagnostic" (bug reported by telemetry) #64547

adonovan commented Dec 5, 2023 •

edited

adonovan commented Dec 26, 2023 •

edited

gopherbot commented Jan 18, 2024

adonovan commented Mar 7, 2024 •

edited

gopherbot commented Mar 7, 2024

gopherbot commented Mar 8, 2024

adonovan commented Mar 8, 2024

adonovan commented Mar 14, 2024

adonovan commented Mar 14, 2024

adonovan commented Mar 31, 2024

adonovan commented Mar 31, 2024

adonovan commented Apr 4, 2024

adonovan commented Apr 4, 2024

adonovan commented Apr 4, 2024

adonovan commented Apr 4, 2024

gopherbot commented Apr 4, 2024

gopherbot commented Apr 4, 2024

adonovan commented Apr 7, 2024

adonovan commented Apr 7, 2024

adonovan commented Apr 7, 2024

adonovan commented Apr 7, 2024

adonovan commented Apr 7, 2024

adonovan commented Apr 7, 2024

gopherbot commented Apr 9, 2024

adonovan commented Apr 18, 2024

adonovan commented Apr 19, 2024

adonovan commented Apr 19, 2024

adonovan commented Apr 22, 2024

gopherbot commented Apr 22, 2024

adonovan commented Apr 22, 2024

adonovan commented Apr 23, 2024

adonovan commented May 2, 2024

adonovan commented May 3, 2024

x/tools/gopls: "internal error converting diagnostic" (bug reported by telemetry) #64547

x/tools/gopls: "internal error converting diagnostic" (bug reported by telemetry) #64547

Comments

adonovan commented Dec 5, 2023 • edited

adonovan commented Dec 26, 2023 • edited

gopherbot commented Jan 18, 2024

adonovan commented Mar 7, 2024 • edited

gopherbot commented Mar 7, 2024

gopherbot commented Mar 8, 2024

adonovan commented Mar 8, 2024

adonovan commented Mar 14, 2024

adonovan commented Mar 14, 2024

adonovan commented Mar 31, 2024

adonovan commented Mar 31, 2024

adonovan commented Apr 4, 2024

adonovan commented Apr 4, 2024

adonovan commented Apr 4, 2024

adonovan commented Apr 4, 2024

gopherbot commented Apr 4, 2024

gopherbot commented Apr 4, 2024

adonovan commented Apr 7, 2024

adonovan commented Apr 7, 2024

adonovan commented Apr 7, 2024

adonovan commented Apr 7, 2024

adonovan commented Apr 7, 2024

adonovan commented Apr 7, 2024

gopherbot commented Apr 9, 2024

adonovan commented Apr 18, 2024

adonovan commented Apr 19, 2024

adonovan commented Apr 19, 2024

adonovan commented Apr 22, 2024

gopherbot commented Apr 22, 2024

adonovan commented Apr 22, 2024

adonovan commented Apr 23, 2024

adonovan commented May 2, 2024

adonovan commented May 3, 2024

adonovan commented Dec 5, 2023 •

edited

adonovan commented Dec 26, 2023 •

edited

adonovan commented Mar 7, 2024 •

edited