Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/test/integration/workspace: TestUseGoWork failures #64532

Closed
gopherbot opened this issue Dec 4, 2023 · 4 comments
Closed

x/tools/gopls/internal/test/integration/workspace: TestUseGoWork failures #64532

gopherbot opened this issue Dec 4, 2023 · 4 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/workspace" && test == "TestUseGoWork"

Issue created automatically to collect these failures.

Example (log):

#### Start Gopls Test Logs for "TestUseGoWork/default"
[Trace - 09:13:14.838 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"0s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/buildlet/tmp/gopls-test-3023597316/TestUseGoWork/default/gopath","GOPROXY":"file:///tmp/buildlet/tmp/gopls-test-3023597316/TestUseGoWork/default/proxy","GOSUMDB":"off"},"subdirWatchPatterns":"on","verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/buildlet/tmp/gopls-test-3023597316/TestUseGoWork/default/work","name":"work"}]}


[Trace - 09:13:14.839 AM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.add_telemetry_counters","gopls.apply_fix","gopls.change_signature","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.maybe_prompt_for_telemetry","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_go_work_command","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.start_profile","gopls.stop_profile","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor","gopls.workspace_stats"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel de5b418bea70aaf27de1f47e9b5813940d1e15a4\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"(unknown)\"}"}}


[Trace - 09:13:14.839 AM] Sending notification 'initialized'.
...
panic: test timed out after 10m0s
running tests:
	TestUseGoWork (9m40s)
	TestUseGoWork/default (9m40s)

testing.(*T).Run(0x14000e8e000, {0x10118a435?, 0x1011a7335?}, 0x14004416dc0)
	/tmp/buildlet/go/src/testing/testing.go:1750 +0x32c
golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run(0x14000255900, 0x14000e8e000, {0x10120ee29, 0x26b}, 0x101669f28, {0x14000dd7f38, 0x2, 0x10117a034?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:167 +0x3d8
golang.org/x/tools/gopls/internal/test/integration.configuredRunner.Run({{0x14000a5df38?, 0x14003b11020?, 0x1011b0190?}}, 0x14000e8e000, {0x10120ee29, 0x26b}, 0x101669f28)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/regtest.go:80 +0xf0
golang.org/x/tools/gopls/internal/test/integration/workspace.TestUseGoWork(0x14000e8e000)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/workspace/workspace_test.go:553 +0xfc
testing.tRunner(0x14000e8e000, 0x101669c70)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 4, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/workspace" && test == "TestUseGoWork"
2023-12-04 14:11 darwin-arm64-12 tools@184d2a73 go@de5b418b x/tools/gopls/internal/test/integration/workspace.TestUseGoWork (log) 
#### Start Gopls Test Logs for "TestUseGoWork/default"
[Trace - 09:13:14.838 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"0s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/buildlet/tmp/gopls-test-3023597316/TestUseGoWork/default/gopath","GOPROXY":"file:///tmp/buildlet/tmp/gopls-test-3023597316/TestUseGoWork/default/proxy","GOSUMDB":"off"},"subdirWatchPatterns":"on","verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/buildlet/tmp/gopls-test-3023597316/TestUseGoWork/default/work","name":"work"}]}


[Trace - 09:13:14.839 AM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.add_telemetry_counters","gopls.apply_fix","gopls.change_signature","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.maybe_prompt_for_telemetry","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_go_work_command","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.start_profile","gopls.stop_profile","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor","gopls.workspace_stats"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel de5b418bea70aaf27de1f47e9b5813940d1e15a4\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"(unknown)\"}"}}


[Trace - 09:13:14.839 AM] Sending notification 'initialized'.
...
panic: test timed out after 10m0s
running tests:
	TestUseGoWork (9m40s)
	TestUseGoWork/default (9m40s)

testing.(*T).Run(0x14000e8e000, {0x10118a435?, 0x1011a7335?}, 0x14004416dc0)
	/tmp/buildlet/go/src/testing/testing.go:1750 +0x32c
golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run(0x14000255900, 0x14000e8e000, {0x10120ee29, 0x26b}, 0x101669f28, {0x14000dd7f38, 0x2, 0x10117a034?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:167 +0x3d8
golang.org/x/tools/gopls/internal/test/integration.configuredRunner.Run({{0x14000a5df38?, 0x14003b11020?, 0x1011b0190?}}, 0x14000e8e000, {0x10120ee29, 0x26b}, 0x101669f28)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/regtest.go:80 +0xf0
golang.org/x/tools/gopls/internal/test/integration/workspace.TestUseGoWork(0x14000e8e000)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/workspace/workspace_test.go:553 +0xfc
testing.tRunner(0x14000e8e000, 0x101669c70)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 4, 2023
@gopherbot gopherbot added this to the Unreleased milestone Dec 4, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/546855 mentions this issue: Revert "gopls/internal/server: rewrite the server diagnostic tracking"

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/workspace" && test == "TestUseGoWork"
2024-01-10 16:06 darwin-amd64-longtest tools@706525de go@e9b3ff15 x/tools/gopls/internal/test/integration/workspace.TestUseGoWork (log) 
goroutine profile: total 8
1 @ 0xc4d94d1 0xc51555d 0xc68fc71 0xc68faa5 0xc68c8cb 0xcd9d250 0xcd9cdd4 0xc5e145b 0xc51c2e1
#	0xc51555c	runtime/pprof.runtime_goroutineProfileWithLabels+0x1c				/tmp/buildlet/go/src/runtime/mprof.go:1079
#	0xc68fc70	runtime/pprof.writeRuntimeProfile+0xb0						/tmp/buildlet/go/src/runtime/pprof/pprof.go:774
#	0xc68faa4	runtime/pprof.writeGoroutine+0x44						/tmp/buildlet/go/src/runtime/pprof/pprof.go:734
#	0xc68c8ca	runtime/pprof.(*Profile).WriteTo+0x14a						/tmp/buildlet/go/src/runtime/pprof/pprof.go:369
#	0xcd9d24f	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:207
#	0xcd9cdd3	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xc53	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:255
#	0xc5e145a	testing.tRunner+0xfa								/tmp/buildlet/go/src/testing/testing.go:1689

...
#	0xc8bf24e	golang.org/x/tools/go/packages.defaultDriver+0x6e					/tmp/buildlet/gopath/src/golang.org/x/tools/go/packages/packages.go:305
#	0xc8beef3	golang.org/x/tools/go/packages.Load+0x53						/tmp/buildlet/gopath/src/golang.org/x/tools/go/packages/packages.go:262
#	0xcbcb70b	golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).load+0xcab			/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/load.go:136
#	0xcbe7c24	golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).MetadataForFile+0x304		/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/snapshot.go:796
#	0xcbb4b8c	golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).resolveImportGraph+0x1ec	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:207
#	0xcbb4865	golang.org/x/tools/gopls/internal/lsp/cache.(*Snapshot).getImportGraph.func1+0x65	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:167

--- FAIL: TestUseGoWork (12.86s)
    --- FAIL: TestUseGoWork/experimental (4.47s)
        runner.go:208: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /tmp/buildlet/tmp/gopls-test-2133190084/TestUseGoWork/experimental: directory not empty

— watchflakes

@gopherbot gopherbot reopened this Jan 11, 2024
@findleyr
Copy link
Member

Dupe of #64971. Clearly there's something I don't understand about WatchFlakes.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2024
@golang golang locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @findleyr