image/jpeg: Decoding returns EOF instead of ErrUnexpectedEOF for JPEG files with missing segments #6450
Labels
Comments
|
Labels changed: added priority-later, packagebug, removed priority-triage. Owner changed to @nigeltao. Status changed to Accepted. |
|
Comment 3 by rdamazio@google.com: Just a thought - maybe it should return err AND img, with img containing partial contents like what's rendered above. |
I agree with the general sentiment, although I think it should be a jpeg.FormatError instead of io.ErrUnexpectedEOF. As for comment #3, I generally don't like being "liberal in what we accept"; this is arguably simply an invalid JPEG image. Yes, there is already precedent in the image/jpeg code in being a little liberal, but I didn't really like that either. If your program really needs to accept corrupted JPEG images, then you can always fork image/jpeg. |
|
This issue was closed by revision c2013e8. Status changed to Fixed. |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What steps will reproduce the problem? import ( "image" _ "image/jpeg" ) img, format, err := image.Decode(jpegImageWithMissingSegmentsReader) What is the expected output? Unexpected EOF should be returned. What do you see instead? EOF is returned in some cases if there are missing segments in the image file. Attached file reproduces the problem. Which operating system are you using? Darwin Kernel Version 12.4.0 Which version are you using? (run 'go version') go version go1.1.2 darwin/386Attachments:
The text was updated successfully, but these errors were encountered: