Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: flag modcacherw does not take effect in the target package [1.21 backport] #64497

Closed
gopherbot opened this issue Dec 1, 2023 · 5 comments
Closed

cmd/go: flag modcacherw does not take effect in the target package [1.21 backport] #64497

gopherbot opened this issue Dec 1, 2023 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go
Milestone
Go1.21.7

Comments

@gopherbot
Copy link

@bcmills requested issue #64282 to be considered for backport to the next 1.21 minor release.

@gopherbot, please backport to Go 1.21. This was a regression in Go 1.21 and has no clear workaround.
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases GoCommand cmd/go labels Dec 1, 2023
@gopherbot gopherbot mentioned this issue Dec 1, 2023
Closed
@gopherbot gopherbot added this to the Go1.21.5 milestone Dec 1, 2023
@bcmills
Copy link
Contributor

bcmills commented Dec 1, 2023 •
edited

The fix for this seems straightforward and poses almost no risk to code outside of go install pkg@version and go run pkg@version. Approving for backport.

@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Dec 1, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Dec 1, 2023
@gopherbot gopherbot modified the milestones: Go1.21.5, Go1.21.6 Dec 5, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/550055 mentions this issue: [release-branch.go1.21] cmd/go/internal/toolchain: make a best effort to parse 'go run' and 'go install' flags

@thanm
Copy link
Contributor

thanm commented Dec 19, 2023

Note: the fix for this issue on master was reverted in CL 551215, so we'll need to decide what to do with this issue.

@gopherbot gopherbot modified the milestones: Go1.21.6, Go1.21.7 Jan 9, 2024
@cherrymui cherrymui added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jan 25, 2024
@bcmills bcmills removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jan 29, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/559198 mentions this issue: [release-branch.go1.21] cmd/go/internal/toolchain: apply the -modcacherw flag when downloading a module to determine what toolchain it needs

@gopherbot
Copy link
Author

Closed by merging 6552f3d to release-branch.go1.21.

gopherbot pushed a commit that referenced this issue Jan 31, 2024
@mknyszek
[release-branch.go1.21] cmd/go/internal/toolchain: apply the -modcach…
6552f3d 
…erw flag when downloading a module to determine what toolchain it needs

Fixes #64497.
Updates #64282.

Change-Id: I3f211c599ee70cb58254d0bc07eeb3c135124e58
Reviewed-on: https://go-review.googlesource.com/c/go/+/555436
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
(cherry picked from commit cc38c68)
Reviewed-on: https://go-review.googlesource.com/c/go/+/559198
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go
Projects
None yet
Milestone
Go1.21.7
Development

No branches or pull requests
4 participants
@bcmills @gopherbot @thanm @cherrymui