Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: marker tests are broken on small machines #64496

Closed
findleyr opened this issue Dec 1, 2023 · 3 comments
Closed

x/tools/gopls: marker tests are broken on small machines #64496

findleyr opened this issue Dec 1, 2023 · 3 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.15.0

Comments

@findleyr
Copy link
Contributor

findleyr commented Dec 1, 2023

It looks like https://go.dev/cl/546255 somehow broke the testenv.ExitIfSmallMachine skip, and now tests are broken on small builders:

skipping test: assuming that android is resource-constrained
--- FAIL: Test (0.00s)
panic: unexpected call to os.Exit(0) during test [recovered]
	panic: unexpected call to os.Exit(0) during test

CC @adonovan
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 1, 2023
@gopherbot gopherbot added this to the Unreleased milestone Dec 1, 2023
@findleyr
Copy link
Contributor Author

findleyr commented Dec 1, 2023

Oh, the call to ExitIfSmallMachine was moved from TestMain to Test. I'll fix.

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.15.0 Dec 1, 2023
@findleyr findleyr self-assigned this Dec 1, 2023
@gopherbot
Copy link

Change https://go.dev/cl/546336 mentions this issue: gopls/internal/test/marker: move ExitIfSmallMachine back to TestMain

@adonovan
Copy link
Member

adonovan commented Dec 1, 2023

Oh, the call to ExitIfSmallMachine was moved from TestMain to Test. I'll fix.

Sorry about that; I forgot that it's not a simple skip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.15.0
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr