Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/build: add go1.2 build tag #6449

Closed
speter opened this issue Sep 22, 2013 · 5 comments
Closed

go/build: add go1.2 build tag #6449

speter opened this issue Sep 22, 2013 · 5 comments

Comments

@speter
Copy link

speter commented Sep 22, 2013

What steps will reproduce the problem?
If possible, include a link to a program on play.golang.org.
1. Create a new source file with "// +build go1.2" in an empty directory (e.g.
http://play.golang.org/p/XdsZLcRp1L )
2. Run "go build" in that directory

What is the expected output?
Successful build

What do you see instead?
"can't load package: package .: no buildable Go source files in ${CWD}"

Which compiler are you using (5g, 6g, 8g, gccgo)?
8g

Which operating system are you using?
Linux (Ubuntu 12.04/i386)

Which version are you using?  (run 'go version')
go version devel +00ff0c821b3f Sun Sep 22 10:56:06 2013 -0700 linux/386

Please provide any additional information below.
It would be nice if this could be always added by the time of release candidates. This
would allow people developing packages for which the build depends on Go API changes to
ensure build compatibility with "the real thing" (without specifying the
expected tag manually) sooner.
@adg
Copy link
Contributor

adg commented Sep 22, 2013

Comment 1:

Yep, we should do this before the next release candidate.

Status changed to Accepted.

@speter
Copy link
Author

speter commented Sep 23, 2013

Comment 2:

Sent https://golang.org/cl/13829044/ for go1.2 .
Is there a release checklist etc. where this could be added so it is not forgotten for
go1.3+? (Or I can just file issues for each of 1.3 / 1.4 etc...)

@adg
Copy link
Contributor

adg commented Sep 23, 2013

Comment 3:

It wasn't forgotten. It's just early.

@speter
Copy link
Author

speter commented Sep 23, 2013

Comment 4:

Sorry for the false accusation. I was just assuming that rc's would be close to the
release version and include the build tag, but I now have noticed that 1.2rc1 is
positioned more as a "beta".

@adg
Copy link
Contributor

adg commented Sep 23, 2013

Comment 5:

This issue was closed by revision 3861cb4.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants