Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: package doc contains outdated linker flags #64476

Closed
dagood opened this issue Nov 30, 2023 · 3 comments
Closed

cmd/link: package doc contains outdated linker flags #64476

dagood opened this issue Nov 30, 2023 · 3 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Go1.22

Comments

@dagood
Copy link
Contributor

dagood commented Nov 30, 2023

Go version

go version devel go1.22-bb8a96fa54 Fri Nov 17 21:25:34 2023 +0000 windows/amd64

What operating system and processor architecture are you using (go env)?

set GOARCH=amd64
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
...

What did you do?

I ran go doc cmd/link and go tool link to see what flags are available.

What did you expect to see?

The list of valid flags should be the same in both results. The descriptions might be a little different (e.g. the doc might have more detailed info).

What did you see instead?

The lists of flags are different.

Example: -u is in go doc cmd/link:

    -u
        Reject unsafe packages.

However, this flag was removed a few years ago in https://go-review.googlesource.com/c/go/+/236117 and doesn't show up in go tool link --help.
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Nov 30, 2023
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 1, 2023
@dmitshur dmitshur added this to the Backlog milestone Dec 1, 2023
@dmitshur dmitshur added the Suggested Issues that may be good for new contributors looking for work to do. label Dec 1, 2023
@dmitshur
Copy link
Contributor

dmitshur commented Dec 1, 2023

Thanks for reporting. I added Suggested since this seems like a good issue for someone looking to send a CL to fix.

CC @golang/compiler.

@gopherbot
Copy link

Change https://go.dev/cl/546615 mentions this issue: cmd/link: update flag doc

@dagood
Copy link
Contributor Author

dagood commented Dec 1, 2023

Thanks! I was thinking about submitting a CL myself, but figured I probably didn't have the context to make a full proper update so filed this first. 🙂

@dmitshur dmitshur modified the milestones: Backlog, Go1.22 Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Go1.22
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @dagood