Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: activate telemetry upload only in serve #64425

Closed
hyangah opened this issue Nov 28, 2023 · 1 comment
Closed

x/tools/gopls: activate telemetry upload only in serve #64425

hyangah opened this issue Nov 28, 2023 · 1 comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@hyangah
Copy link
Contributor

hyangah commented Nov 28, 2023 •
edited

What did you expect to see?

Telemetry uploading is not a cheap operation and better to run only during long-lived gopls command execution.

What did you see instead?

telemetry upload goroutine starts even with commands like gopls version
@hyangah hyangah added gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. labels Nov 28, 2023
@gopherbot gopherbot added this to the Unreleased milestone Nov 28, 2023
@gopherbot
Copy link

Change https://go.dev/cl/545475 mentions this issue: gopls: enable telemetry uploading only with 'serve'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@hyangah @gopherbot