Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: warn about EOL for Go 1.18 support #64407

Closed
findleyr opened this issue Nov 27, 2023 · 2 comments
Closed

x/tools/gopls: warn about EOL for Go 1.18 support #64407

findleyr opened this issue Nov 27, 2023 · 2 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.15.0

Comments

@findleyr
Copy link
Contributor

Reminder issue: we should mark Go 1.18 as EOL in the next minor gopls release (v0.15.0).

Support will then be removed for gopls@v0.16.0, which will come out shortly after Go 1.22.
@findleyr findleyr added this to the gopls/v0.15.0 milestone Nov 27, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 27, 2023
@findleyr findleyr self-assigned this Dec 12, 2023
@gopherbot
Copy link

Change https://go.dev/cl/549115 mentions this issue: gopls/internal/util/goversion: warn about EOL for Go 1.18

@gopherbot
Copy link

Change https://go.dev/cl/567418 mentions this issue: x/tools: drop go1.18 support

gopherbot pushed a commit to golang/tools that referenced this issue Feb 29, 2024
@adonovan @gopherbot
x/tools: drop go1.18 support
283fce2 
Updates golang/go#64407

Change-Id: I247a7ff7f07613674f8e31e4cb9c5a68762d2203
Reviewed-on: https://go-review.googlesource.com/c/tools/+/567418
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.15.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr