Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/telemetry: TestLatencyInstrumentation failures #64327

Closed
gopherbot opened this issue Nov 22, 2023 · 2 comments
Closed

x/tools/gopls/internal/telemetry: TestLatencyInstrumentation failures #64327

gopherbot opened this issue Nov 22, 2023 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.15.0

Comments

@gopherbot
Copy link 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/telemetry" && test == "TestLatencyInstrumentation"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestLatencyInstrumentation (0.48s)
    telemetry_test.go:212: after 10 completions, completion counter went from 0 to 0

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 22, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/telemetry" && test == "TestLatencyInstrumentation"
2023-11-21 22:07 linux-arm64-race tools@1733061d go@dc5a0d27 x/tools/gopls/internal/telemetry.TestLatencyInstrumentation (log) 
--- FAIL: TestLatencyInstrumentation (0.48s)
    telemetry_test.go:212: after 10 completions, completion counter went from 0 to 0

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 22, 2023
@gopherbot gopherbot added this to the Unreleased milestone Nov 22, 2023
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.15.0 Nov 26, 2023
@findleyr
Copy link
Contributor

I think there are various telemetry failure modes that result in no collection, so I doubt this is easy to investigate, or worthwhile investigating, given how very infrequent it appears to be. In addition, this code has subsequently changed.

Let's close as obsolete.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
gopls/v0.15.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr