Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: bug in typeCheckImpl reported by telemetry #64320

Closed
adonovan opened this issue Nov 21, 2023 · 1 comment
Closed

x/tools/gopls: bug in typeCheckImpl reported by telemetry #64320

adonovan opened this issue Nov 21, 2023 · 1 comment
Assignees
@findleyr
Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.15.0

Comments

@adonovan
Copy link
Member

adonovan commented Nov 21, 2023 •
edited

This stack 1oDUow, 36lZ1w was reported by telemetry:

typeCheckImpl:48 is

			// If we fail here and there are no parse errors, it means we are hiding
			// a valid type-checking error from the user. This must be a bug, with
			// one exception: relocated primary errors may fail processing, because
			// they reference locations outside of the package.
			if len(pkg.parseErrors) == 0 && !e.relocated {
				bug.Reportf("failed to compute position for type error %v: %v", e, err)
			}

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Reportf:1
golang.org/x/tools/gopls/internal/lsp/cache.typeCheckImpl:48
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).checkPackage:7
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).handleSyntaxPackage:59
golang.org/x/tools/gopls/internal/lsp/cache.(*snapshot).forEachPackageInternal.func2:1
golang.org/x/sync/errgroup.(*Group).Go.func1:3
runtime.goexit:0

golang.org/x/tools/gopls@v0.14.1 go1.21.1 linux/amd64 (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.
@adonovan adonovan added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. gopls/telemetry-wins labels Nov 21, 2023
@gopherbot gopherbot added this to the Unreleased milestone Nov 21, 2023
@adonovan adonovan changed the title x/tools/gopls: bug reported by telemetry x/tools/gopls: bug in typeCheckImpl reported by telemetry Nov 21, 2023
@adonovan adonovan assigned adonovan and findleyr and unassigned adonovan Nov 21, 2023
@findleyr findleyr mentioned this issue Nov 22, 2023
Open
@gopherbot
Copy link

Change https://go.dev/cl/537735 mentions this issue: gopls/internal/lsp/cache: clean up unnecessary type checking indirection

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.15.0 Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.15.0
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr