Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/arch: licensing and INTEL CONFIDENTIAL #64315

Closed
claesbuckwalter opened this issue Nov 21, 2023 · 5 comments
Closed

x/arch: licensing and INTEL CONFIDENTIAL #64315

claesbuckwalter opened this issue Nov 21, 2023 · 5 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@claesbuckwalter
Copy link

I am not sure this is a bug or not. Our legal team was reviewing the licenses of module golang.org/x/arch@v0.5.0 and found that this testdata file mentions "INTEL CONFIDENTIAL" in two places:

https://github.com/golang/arch/blob/master/x86/x86avxgen/testdata/xedpath/all-dec-instructions.txt#L11878
https://github.com/golang/arch/blob/master/x86/x86avxgen/testdata/xedpath/all-dec-instructions.txt#L25538

Example below.

Is there content in golang.org/x/arch that should be removed because it is governed by the "INTEL CONFIDENTIAL" paragraphs? Or can the "INTEL CONFIDENTIAL" paragraphs be removed?

###FILE: ./datafiles/avx512f/avx512-foundation-isa.xed.txt

#BEGIN_LEGAL
#INTEL CONFIDENTIAL
#
#Copyright (c) 2017, Intel Corporation. All rights reserved.
#
#The source code contained or described herein and all documents
#related to the source code ("Material") are owned by Intel Corporation
#or its suppliers or licensors. Title to the Material remains with
#Intel Corporation or its suppliers and licensors. The Material
#contains trade secrets and proprietary and confidential information of
#Intel or its suppliers and licensors. The Material is protected by
#worldwide copyright and trade secret laws and treaty provisions. No
#part of the Material may be used, copied, reproduced, modified,
#published, uploaded, posted, transmitted, distributed, or disclosed in
#any way without Intel's prior express written permission.
#
#No license under any patent, copyright, trade secret or other
#intellectual property right is granted to or conferred upon you by
#disclosure or delivery of the Materials, either expressly, by
#implication, inducement, estoppel or otherwise. Any license under such
#intellectual property rights must be express and approved by Intel in
#writing.
#END_LEGAL
#
#
#
#    ***** GENERATED FILE -- DO NOT EDIT! *****
#    ***** GENERATED FILE -- DO NOT EDIT! *****
#    ***** GENERATED FILE -- DO NOT EDIT! *****
#
#
#
EVEX_INSTRUCTIONS()::
# EMITTING VADDPD (VADDPD-512-1)
{
ICLASS:      VADDPD
CPL:         3
CATEGORY:    AVX512
EXTENSION:   AVX512EVEX
ISA_SET:     AVX512F_512
EXCEPTIONS:     AVX512-E2
REAL_OPCODE: Y
ATTRIBUTES:  MASKOP_EVEX MXCSR
PATTERN:    EVV 0x58 V66 V0F MOD[0b11] MOD=3 BCRC=0 REG[rrr] RM[nnn]  VL512  W1
OPERANDS:    REG0=ZMM_R3():w:zf64 REG1=MASK1():r:mskw:TXT=ZEROSTR REG2=ZMM_N3():r:zf64 REG3=ZMM_B3():r:zf64
IFORM:       VADDPD_ZMMf64_MASKmskw_ZMMf64_ZMMf64_AVX512
}
...
@mknyszek mknyszek changed the title affected/package: golang.org/x/arch x/arch: licensing and INTEL CONFIDENTIAL Nov 21, 2023
@mknyszek
Copy link
Contributor

CC @rsc

@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 21, 2023
@mknyszek mknyszek added this to the Backlog milestone Nov 21, 2023
@claesbuckwalter
Copy link
Author

Some more context: When we use open software in our product, our legal team digs through the source code and reviews any licenses they find. They found this and flagged it.

@gophun
Copy link

gophun commented Nov 22, 2023

@gopherbot
Copy link

Change https://go.dev/cl/547775 mentions this issue: x86avxgen/testdata/xedpath: replace "INTEL CONFIDENTIAL" files

@rsc
Copy link
Contributor

rsc commented Dec 6, 2023

These were copied from github.com/intelxed/xed, and those files were later corrected to update the copyright lines. I have sent a CL that copies in newer versions from that repo that are correctly marked with Apache licenses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

5 participants